enable/disable auto partition creation

zilder · zilder · commit d7665c3800b0 · 2016-08-26T11:42:15.000+03:00
diff --git a/expected/pg_pathman.out b/expected/pg_pathman.out
@@ -1256,8 +1256,23 @@ SELECT * FROM test.range_rel WHERE dt = '2015-03-15';
  74 | Sun Mar 15 00:00:00 2015
 (1 row)
 
+SELECT pathman.disable_auto('test.range_rel');
+ disable_auto 
+--------------
+ 
+(1 row)
+
+INSERT INTO test.range_rel (dt) VALUES ('2015-06-01');
+ERROR:  There is no suitable partition for key 'Mon Jun 01 00:00:00 2015'
+SELECT pathman.enable_auto('test.range_rel');
+ enable_auto 
+-------------
+ 
+(1 row)
+
+INSERT INTO test.range_rel (dt) VALUES ('2015-06-01');
 DROP TABLE test.range_rel CASCADE;
-NOTICE:  drop cascades to 16 other objects
+NOTICE:  drop cascades to 20 other objects
 SELECT partrel, attname, parttype, range_interval FROM pathman.pathman_config;
  partrel | attname | parttype | range_interval 
 ---------+---------+----------+----------------
diff --git a/sql/pg_pathman.sql b/sql/pg_pathman.sql
@@ -525,6 +525,11 @@ SELECT * FROM test.range_rel WHERE dt = '2014-12-15';
 EXPLAIN (COSTS OFF) SELECT * FROM test.range_rel WHERE dt = '2015-03-15';
 SELECT * FROM test.range_rel WHERE dt = '2015-03-15';
 
+SELECT pathman.disable_auto('test.range_rel');
+INSERT INTO test.range_rel (dt) VALUES ('2015-06-01');
+SELECT pathman.enable_auto('test.range_rel');
+INSERT INTO test.range_rel (dt) VALUES ('2015-06-01');
+
 DROP TABLE test.range_rel CASCADE;
 SELECT partrel, attname, parttype, range_interval FROM pathman.pathman_config;
 
diff --git a/src/partition_filter.c b/src/partition_filter.c
@@ -204,12 +204,20 @@ partition_filter_exec(CustomScanState *node)
 			elog(ERROR, "PartitionFilter selected more than one partition");
 		else if (nparts == 0)
 		{
-			selected_partid = create_partitions(state->partitioned_table,
-												state->temp_const.constvalue,
-												state->temp_const.consttype);
+			if (prel->auto_partition)
+			{
+				selected_partid = create_partitions(state->partitioned_table,
+													state->temp_const.constvalue,
+													state->temp_const.consttype);
 
-			/* get_pathman_relation_info() will refresh this entry */
-			invalidate_pathman_relation_info(state->partitioned_table, NULL);
+				/* get_pathman_relation_info() will refresh this entry */
+				invalidate_pathman_relation_info(state->partitioned_table, NULL);
+			}
+			else
+				elog(ERROR,
+					 "There is no suitable partition for key '%s'",
+					 datum_to_cstring(state->temp_const.constvalue,
+					 				  state->temp_const.consttype));
 		}
 		else
 			selected_partid = parts[0];
