Bug (yet unfixed but not fatal) found: Re-moving index clauses from the

vadim4o · vadim4o · commit e349eb6e2c90 · 1997-04-24T15:59:58.000Z
nestloop's join clauses doesn't work in some cases:
         *    1. fix_indxqual_references may change varattno-s in
         *       inner_indxqual;
         *    2. clauses may be commuted
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/optimizer/plan/createplan.c,v 1.10 1997/04/22 03:30:36 vadim Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/optimizer/plan/createplan.c,v 1.11 1997/04/24 15:59:58 vadim Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -432,7 +432,7 @@ create_nestloop_node(JoinPath *best_path,
 
 	foreach (inner_qual, inner_indxqual)
 	{
-	    if ( !(qual_clause_p ((Node*)inner_qual)) )
+	    if ( !qual_clause_p ((Node*)lfirst(inner_qual)) )
 	    {
 	    	found = true;
 	    	break;
@@ -443,12 +443,18 @@ create_nestloop_node(JoinPath *best_path,
 	 * index clauses from the nestloop's join clauses and reset the 
 	 * inner(index) scan's qualification so that the var nodes refer to
 	 * the proper outer join relation attributes.
+	 *
+	 * XXX Re-moving index clauses doesn't work properly: 
+	 *    1. fix_indxqual_references may change varattno-s in 
+	 *       inner_indxqual;
+	 *    2. clauses may be commuted
+	 * I havn't time to fix it at the moment.   - vadim 04/24/97
 	 */
 	if  ( found )
 	{
 	    List *new_inner_qual = NIL;
 	    
-	    clauses = set_difference(clauses,inner_indxqual);
+	    clauses = set_difference(clauses,inner_indxqual);	/* XXX */
 	    new_inner_qual =
 		index_outerjoin_references(inner_indxqual,
 					   outer_node->targetlist,

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/optimizer/plan/createplan.c,v 1.10 1997/04/22 03:30:36 vadim Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/optimizer/plan/createplan.c,v 1.11 1997/04/24 15:59:58 vadim Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -432,7 +432,7 @@ create_nestloop_node(JoinPath *best_path,`
`432`	`432`
`433`	`433`	`foreach (inner_qual, inner_indxqual)`
`434`	`434`	`{`
`435`		`- if ( !(qual_clause_p ((Node*)inner_qual)) )`
	`435`	`+ if ( !qual_clause_p ((Node*)lfirst(inner_qual)) )`
`436`	`436`	`{`
`437`	`437`	`found = true;`
`438`	`438`	`break;`
`@@ -443,12 +443,18 @@ create_nestloop_node(JoinPath *best_path,`
`443`	`443`	`* index clauses from the nestloop's join clauses and reset the`
`444`	`444`	`* inner(index) scan's qualification so that the var nodes refer to`
`445`	`445`	`* the proper outer join relation attributes.`
	`446`	`+ *`
	`447`	`+ * XXX Re-moving index clauses doesn't work properly:`
	`448`	`+ * 1. fix_indxqual_references may change varattno-s in`
	`449`	`+ * inner_indxqual;`
	`450`	`+ * 2. clauses may be commuted`
	`451`	`+ * I havn't time to fix it at the moment. - vadim 04/24/97`
`446`	`452`	`*/`
`447`	`453`	`if ( found )`
`448`	`454`	`{`
`449`	`455`	`List *new_inner_qual = NIL;`
`450`	`456`
`451`		`- clauses = set_difference(clauses,inner_indxqual);`
	`457`	`+ clauses = set_difference(clauses,inner_indxqual); /* XXX */`
`452`	`458`	`new_inner_qual =`
`453`	`459`	`index_outerjoin_references(inner_indxqual,`
`454`	`460`	`outer_node->targetlist,`