cluster: make DefaultSyncTimeout infinite.

sgotti · sgotti · commit 709a3d0d07aa · 2020-01-22T09:28:58.000+01:00
SyncTimeout is currently undocumented and is set to 30 minutes causing
unexpected behaviors to users.

So make its default set to 0 (infinite).

Another PR will document it.
diff --git a/internal/cluster/cluster.go b/internal/cluster/cluster.go
@@ -55,7 +55,7 @@ const (
 	DefaultRequestTimeout                             = 10 * time.Second
 	DefaultConvergenceTimeout                         = 30 * time.Second
 	DefaultInitTimeout                                = 5 * time.Minute
-	DefaultSyncTimeout                                = 30 * time.Minute
+	DefaultSyncTimeout                                = 0
 	DefaultFailInterval                               = 20 * time.Second
 	DefaultDeadKeeperRemovalInterval                  = 48 * time.Hour
 	DefaultMaxStandbys               uint16           = 20
diff --git a/internal/postgresql/postgresql.go b/internal/postgresql/postgresql.go
@@ -342,7 +342,7 @@ func (p *Manager) start(args ...string) error {
 	// Wait for the correct pid file to appear or for the process to exit
 	ok := false
 	start := time.Now()
-	for time.Now().Add(-startTimeout).Before(start) {
+	for time.Since(start) < startTimeout {
 		fh, err := os.Open(filepath.Join(p.dataDir, "postmaster.pid"))
 		if err == nil {
 			scanner := bufio.NewScanner(fh)
@@ -485,7 +485,7 @@ func (p *Manager) Restart(fast bool) error {
 
 func (p *Manager) WaitReady(timeout time.Duration) error {
 	start := time.Now()
-	for time.Now().Add(-timeout).Before(start) {
+	for timeout == 0 || time.Since(start) < timeout {
 		if err := p.Ping(); err == nil {
 			return nil
 		}
@@ -502,7 +502,7 @@ func (p *Manager) WaitRecoveryDone(timeout time.Duration) error {
 
 	start := time.Now()
 	if maj >= 12 {
-		for time.Now().Add(-timeout).Before(start) {
+		for timeout == 0 || time.Since(start) < timeout {
 			_, err := os.Stat(filepath.Join(p.dataDir, postgresRecoverySignal))
 			if err != nil && !os.IsNotExist(err) {
 				return err
@@ -513,7 +513,7 @@ func (p *Manager) WaitRecoveryDone(timeout time.Duration) error {
 			time.Sleep(1 * time.Second)
 		}
 	} else {
-		for time.Now().Add(-timeout).Before(start) {
+		for timeout == 0 || time.Since(start) < timeout {
 			_, err := os.Stat(filepath.Join(p.dataDir, postgresRecoveryDone))
 			if err != nil && !os.IsNotExist(err) {
 				return err
