-
-
Notifications
You must be signed in to change notification settings - Fork 1
Update 0000-router-dynamic-routing.md #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just some grammatical corrections. Hope you don't mind. Scott
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks! I think I need to learn about breaks with ,
. I keep missing them between logical connectors in sentences
It's easy (and sometimes I get carried away with commas myself), but if there is a conjugation of two clauses, you can always use a comma. They should definitely be used, if the conjugated clause can be a sentence on its own. (like "You can always use a comma." above.) 😁 And sometimes, you can break them up in different sentences too. Scott |
I see, thanks! I still need to document myself a bit more because I wouldn't have used a comma in They should definitely be used, if the conjugated.... I would have use a dot to break instead. But I wonder if that one was optional |
Do you mean, They should definitely be used. If the conjugated clause can be a sentence on its own. ??? That would be incorrect. 😃 My first sentence could have been broken up. It's easy (and sometimes I get carried away with commas myself). But, if there is a conjugation of two clauses, you can always use a comma. Scott |
Right, that second sentence starting with If doesn't make sense on itself. I realize I removed a part I wanted to say: I would have not included any comma at all instead. What I wanted to say is that I would have rather used a stop (I see now it doesn't make sense though) |
No worries. Your English is pretty darn good, because the important thing is to get the point across, and you seem to be able to do that well. (more examples there of conjugation with a comma 😁) Scott |
Thank you 🙂 |
It was optional, but more proper with a comma, because the last clause could be a sentence on its own. 😁 Keep up the good work and I'll shut up now. 😁 I get a good opportunity to keep learning, and I want to take it! Scott |
* Dynamic Routing * precision from * add getRoutes * add alternative for getRoutes * fix: typo in 0000-router-dynamic-routing.md (#1) * fix typo (#2) * Update 0000-router-dynamic-routing.md (#3) Just some grammatical corrections. Hope you don't mind. Scott * remove template drawbacks * update * rename Symbol to symbol, type typo * rename Co-authored-by: pierresaid <said.pierre.emler@gmail.com> Co-authored-by: atilkan <emrahatilkan@gmail.com> Co-authored-by: Scott <smolinari@users.noreply.github.com>
Just some grammatical corrections. Hope you don't mind.
Scott