Skip to content

Update 0000-router-dynamic-routing.md #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

smolinari
Copy link

Just some grammatical corrections. Hope you don't mind.

Scott

Just some grammatical corrections. Hope you don't mind.

Scott
Copy link
Owner

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! I think I need to learn about breaks with ,. I keep missing them between logical connectors in sentences

@posva posva merged commit 8f403b6 into posva:router/dynamic-routing Jan 29, 2020
@smolinari
Copy link
Author

smolinari commented Jan 29, 2020

It's easy (and sometimes I get carried away with commas myself), but if there is a conjugation of two clauses, you can always use a comma. They should definitely be used, if the conjugated clause can be a sentence on its own. (like "You can always use a comma." above.) 😁

And sometimes, you can break them up in different sentences too.

Scott

@posva
Copy link
Owner

posva commented Jan 29, 2020

I see, thanks! I still need to document myself a bit more because I wouldn't have used a comma in They should definitely be used, if the conjugated.... I would have use a dot to break instead. But I wonder if that one was optional

@smolinari
Copy link
Author

smolinari commented Jan 29, 2020

Do you mean,

They should definitely be used. If the conjugated clause can be a sentence on its own.

???

That would be incorrect. 😃

My first sentence could have been broken up.

It's easy (and sometimes I get carried away with commas myself). But, if there is a conjugation of two clauses, you can always use a comma.

Scott

@posva
Copy link
Owner

posva commented Jan 29, 2020

Right, that second sentence starting with If doesn't make sense on itself. I realize I removed a part I wanted to say: I would have not included any comma at all instead. What I wanted to say is that I would have rather used a stop (I see now it doesn't make sense though)

@smolinari
Copy link
Author

No worries. Your English is pretty darn good, because the important thing is to get the point across, and you seem to be able to do that well. (more examples there of conjugation with a comma 😁)

Scott

@posva
Copy link
Owner

posva commented Jan 29, 2020

Thank you 🙂
Yeah, I also feel like I usually get my point across 😆. Since I use English everyday way more than Spanish and French, I get a good opportunity to keep learning and I want to take it! Thanks for the lesson haha

@smolinari
Copy link
Author

I get a good opportunity to keep learning and I want to take it!

It was optional, but more proper with a comma, because the last clause could be a sentence on its own. 😁 Keep up the good work and I'll shut up now. 😁

I get a good opportunity to keep learning, and I want to take it!

Scott

posva added a commit that referenced this pull request Apr 30, 2020
* Dynamic Routing

* precision from

* add getRoutes

* add alternative for getRoutes

* fix: typo in 0000-router-dynamic-routing.md (#1)

* fix typo (#2)

* Update 0000-router-dynamic-routing.md (#3)

Just some grammatical corrections. Hope you don't mind.

Scott

* remove template drawbacks

* update

* rename Symbol to symbol, type typo

* rename

Co-authored-by: pierresaid <said.pierre.emler@gmail.com>
Co-authored-by: atilkan <emrahatilkan@gmail.com>
Co-authored-by: Scott <smolinari@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants