dont use CAPS for non consts

leebyron · leebyron · commit 54ff95db56db · 2014-10-10T16:06:14.000-07:00
diff --git a/dist/Immutable.js b/dist/Immutable.js
@@ -124,15 +124,15 @@ function hash(o) {
   return hashJSObj(o);
 }
 function cachedHashString(string) {
-  var hash = STRING_HASH_CACHE[string];
+  var hash = stringHashCache[string];
   if (hash == null) {
     hash = hashString(string);
     if (STRING_HASH_CACHE_SIZE === STRING_HASH_CACHE_MAX_SIZE) {
       STRING_HASH_CACHE_SIZE = 0;
-      STRING_HASH_CACHE = {};
+      stringHashCache = {};
     }
     STRING_HASH_CACHE_SIZE++;
-    STRING_HASH_CACHE[string] = hash;
+    stringHashCache[string] = hash;
   }
   return hash;
 }
@@ -156,7 +156,7 @@ function hashJSObj(obj) {
       return hash;
   }
   if (!canDefineProperty || Object.isExtensible(obj)) {
-    hash = ++UID_HASH_COUNT & HASH_MAX_VAL;
+    hash = ++objHashUID & HASH_MAX_VAL;
     if (canDefineProperty) {
       Object.defineProperty(obj, UID_HASH_KEY, {
         'enumerable': false,
@@ -199,15 +199,15 @@ function getIENodeHash(node) {
   }
 }
 var HASH_MAX_VAL = 0x7FFFFFFF;
-var UID_HASH_COUNT = 0;
+var objHashUID = 0;
 var UID_HASH_KEY = '__immutablehash__';
 if (typeof Symbol !== 'undefined') {
   UID_HASH_KEY = Symbol(UID_HASH_KEY);
 }
 var STRING_HASH_CACHE_MIN_STRLEN = 16;
 var STRING_HASH_CACHE_MAX_SIZE = 255;
 var STRING_HASH_CACHE_SIZE = 0;
-var STRING_HASH_CACHE = {};
+var stringHashCache = {};
 var Sequence = function Sequence(value) {
   return $Sequence.from(arguments.length === 1 ? value : Array.prototype.slice.call(arguments));
 };
diff --git a/src/Hash.js b/src/Hash.js
@@ -35,15 +35,15 @@ function hash(o) {
 }
 
 function cachedHashString(string) {
-  var hash = STRING_HASH_CACHE[string];
+  var hash = stringHashCache[string];
   if (hash == null) {
     hash = hashString(string);
     if (STRING_HASH_CACHE_SIZE === STRING_HASH_CACHE_MAX_SIZE) {
       STRING_HASH_CACHE_SIZE = 0;
-      STRING_HASH_CACHE = {};
+      stringHashCache = {};
     }
     STRING_HASH_CACHE_SIZE++;
-    STRING_HASH_CACHE[string] = hash;
+    stringHashCache[string] = hash;
   }
   return hash;
 }
@@ -76,7 +76,7 @@ function hashJSObj(obj) {
   }
 
   if (!canDefineProperty || Object.isExtensible(obj)) {
-    hash = ++UID_HASH_COUNT & HASH_MAX_VAL;
+    hash = ++objHashUID & HASH_MAX_VAL;
 
     if (canDefineProperty) {
       Object.defineProperty(obj, UID_HASH_KEY, {
@@ -137,7 +137,8 @@ function getIENodeHash(node) {
 
 var HASH_MAX_VAL = 0x7FFFFFFF; // 2^31 - 1 is an efficiently stored int
 
-var UID_HASH_COUNT = 0;
+var objHashUID = 0;
+
 var UID_HASH_KEY = '__immutablehash__';
 if (typeof Symbol !== 'undefined') {
   UID_HASH_KEY = Symbol(UID_HASH_KEY);
@@ -146,4 +147,4 @@ if (typeof Symbol !== 'undefined') {
 var STRING_HASH_CACHE_MIN_STRLEN = 16;
 var STRING_HASH_CACHE_MAX_SIZE = 255;
 var STRING_HASH_CACHE_SIZE = 0;
-var STRING_HASH_CACHE = {};
+var stringHashCache = {};

Original file line number	Diff line number	Diff line change
`@@ -124,15 +124,15 @@ function hash(o) {`
`124`	`124`	`return hashJSObj(o);`
`125`	`125`	`}`
`126`	`126`	`function cachedHashString(string) {`
`127`		`- var hash = STRING_HASH_CACHE[string];`
	`127`	`+ var hash = stringHashCache[string];`
`128`	`128`	`if (hash == null) {`
`129`	`129`	`hash = hashString(string);`
`130`	`130`	`if (STRING_HASH_CACHE_SIZE === STRING_HASH_CACHE_MAX_SIZE) {`
`131`	`131`	`STRING_HASH_CACHE_SIZE = 0;`
`132`		`- STRING_HASH_CACHE = {};`
	`132`	`+ stringHashCache = {};`
`133`	`133`	`}`
`134`	`134`	`STRING_HASH_CACHE_SIZE++;`
`135`		`- STRING_HASH_CACHE[string] = hash;`
	`135`	`+ stringHashCache[string] = hash;`
`136`	`136`	`}`
`137`	`137`	`return hash;`
`138`	`138`	`}`
`@@ -156,7 +156,7 @@ function hashJSObj(obj) {`
`156`	`156`	`return hash;`
`157`	`157`	`}`
`158`	`158`	`if (!canDefineProperty \|\| Object.isExtensible(obj)) {`
`159`		`- hash = ++UID_HASH_COUNT & HASH_MAX_VAL;`
	`159`	`+ hash = ++objHashUID & HASH_MAX_VAL;`
`160`	`160`	`if (canDefineProperty) {`
`161`	`161`	`Object.defineProperty(obj, UID_HASH_KEY, {`
`162`	`162`	`'enumerable': false,`
`@@ -199,15 +199,15 @@ function getIENodeHash(node) {`
`199`	`199`	`}`
`200`	`200`	`}`
`201`	`201`	`var HASH_MAX_VAL = 0x7FFFFFFF;`
`202`		`-var UID_HASH_COUNT = 0;`
	`202`	`+var objHashUID = 0;`
`203`	`203`	`var UID_HASH_KEY = '__immutablehash__';`
`204`	`204`	`if (typeof Symbol !== 'undefined') {`
`205`	`205`	`UID_HASH_KEY = Symbol(UID_HASH_KEY);`
`206`	`206`	`}`
`207`	`207`	`var STRING_HASH_CACHE_MIN_STRLEN = 16;`
`208`	`208`	`var STRING_HASH_CACHE_MAX_SIZE = 255;`
`209`	`209`	`var STRING_HASH_CACHE_SIZE = 0;`
`210`		`-var STRING_HASH_CACHE = {};`
	`210`	`+var stringHashCache = {};`
`211`	`211`	`var Sequence = function Sequence(value) {`
`212`	`212`	`return $Sequence.from(arguments.length === 1 ? value : Array.prototype.slice.call(arguments));`
`213`	`213`	`};`