clear up Vector index reversal

leebyron · leebyron · commit 5e651ed64298 · 2014-10-08T00:12:27.000-07:00
diff --git a/dist/Immutable.js b/dist/Immutable.js
@@ -1807,9 +1807,9 @@ var $Vector = Vector;
     var vector = this;
     var lastIndex = 0;
     var maxIndex = vector.length - 1;
-    reverseIndices ^= reverse;
+    var flipIndices = reverse && !reverseIndices;
     var eachFn = (function(value, ii) {
-      if (fn(value, reverseIndices ? maxIndex - ii : ii, vector) === false) {
+      if (fn(value, flipIndices ? maxIndex - ii : ii, vector) === false) {
         return false;
       } else {
         lastIndex = ii;
diff --git a/dist/Immutable.min.js b/dist/Immutable.min.js
diff --git a/src/Sequence.js b/src/Sequence.js
@@ -693,6 +693,7 @@ class IndexedSequence extends Sequence {
     )).fromEntrySeq().valueSeq();
   }
 
+  // reverseIndices is only true when reverse is also true
   // abstract __iterateUncached(fn, reverse, reverseIndices)
 
   __iterate(fn, reverse, reverseIndices) {
diff --git a/src/Vector.js b/src/Vector.js
@@ -196,9 +196,9 @@ class Vector extends IndexedSequence {
     var vector = this;
     var lastIndex = 0;
     var maxIndex = vector.length - 1;
-    reverseIndices ^= reverse;
+    var flipIndices = reverse && !reverseIndices;
     var eachFn = (value, ii) => {
-      if (fn(value, reverseIndices ? maxIndex - ii : ii, vector) === false) {
+      if (fn(value, flipIndices ? maxIndex - ii : ii, vector) === false) {
         return false;
       } else {
         lastIndex = ii;

Original file line number	Diff line number	Diff line change
`@@ -693,6 +693,7 @@ class IndexedSequence extends Sequence {`
`693`	`693`	`)).fromEntrySeq().valueSeq();`
`694`	`694`	`}`
`695`	`695`
	`696`	`+ // reverseIndices is only true when reverse is also true`
`696`	`697`	`// abstract __iterateUncached(fn, reverse, reverseIndices)`
`697`	`698`
`698`	`699`	`__iterate(fn, reverse, reverseIndices) {`