Fix unlock of unlocked mutex in tailnet coordinator

kylecarbs · kylecarbs · commit 7851fb1c99ea · 2022-10-17T23:51:41.000Z
diff --git a/tailnet/coordinator.go b/tailnet/coordinator.go
@@ -153,12 +153,10 @@ func (c *coordinator) ServeClient(conn net.Conn, id uuid.UUID, agent uuid.UUID)
 	if ok {
 		data, err := json.Marshal([]*Node{node})
 		if err != nil {
-			c.mutex.Unlock()
 			return xerrors.Errorf("marshal node: %w", err)
 		}
 		_, err = conn.Write(data)
 		if err != nil {
-			c.mutex.Unlock()
 			return xerrors.Errorf("write nodes: %w", err)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -153,12 +153,10 @@ func (c *coordinator) ServeClient(conn net.Conn, id uuid.UUID, agent uuid.UUID)`
`153`	`153`	`if ok {`
`154`	`154`	`data, err := json.Marshal([]*Node{node})`
`155`	`155`	`if err != nil {`
`156`		`- c.mutex.Unlock()`
`157`	`156`	`return xerrors.Errorf("marshal node: %w", err)`
`158`	`157`	`}`
`159`	`158`	`_, err = conn.Write(data)`
`160`	`159`	`if err != nil {`
`161`		`- c.mutex.Unlock()`
`162`	`160`	`return xerrors.Errorf("write nodes: %w", err)`
`163`	`161`	`}`
`164`	`162`	`}`