fix: show all experiments in deployments list if opted into (coder#10722)

Kira-Pilot · web-flow · commit 9f3a955ebff7 · 2023-11-16T10:53:35.000-05:00
diff --git a/site/src/components/DeploySettingsLayout/optionValue.test.ts b/site/src/components/DeploySettingsLayout/optionValue.test.ts
@@ -97,7 +97,11 @@ describe("optionValue", () => {
         value: ["moons"],
       },
       additionalValues: ["single_tailnet", "deployment_health_page"],
-      expected: { single_tailnet: false, deployment_health_page: false },
+      expected: {
+        single_tailnet: false,
+        deployment_health_page: false,
+        moons: true,
+      },
     },
     {
       option: {
@@ -108,6 +112,15 @@ describe("optionValue", () => {
       additionalValues: ["single_tailnet", "deployment_health_page"],
       expected: { single_tailnet: true, deployment_health_page: true },
     },
+    {
+      option: {
+        ...defaultOption,
+        name: "Experiments",
+        value: ["*", "moons", "single_tailnet"],
+      },
+      additionalValues: ["single_tailnet"],
+      expected: { moons: true, single_tailnet: true },
+    },
     {
       option: {
         ...defaultOption,
diff --git a/site/src/components/DeploySettingsLayout/optionValue.ts b/site/src/components/DeploySettingsLayout/optionValue.ts
@@ -50,8 +50,10 @@ export function optionValue(
         break;
       }
 
+      // We show all experiments (including unsafe) that are currently enabled on a deployment
+      // but only show safe experiments that are not.
       for (const v of option.value) {
-        if (Object.hasOwn(experimentMap, v)) {
+        if (v !== "*") {
           experimentMap[v] = true;
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,10 @@ export function optionValue(`
`50`	`50`	`break;`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ // We show all experiments (including unsafe) that are currently enabled on a deployment`
	`54`	`+ // but only show safe experiments that are not.`
`53`	`55`	`for (const v of option.value) {`
`54`		`- if (Object.hasOwn(experimentMap, v)) {`
	`56`	`+ if (v !== "*") {`
`55`	`57`	`experimentMap[v] = true;`
`56`	`58`	`}`
`57`	`59`	`}`