Add sanity check for label value

andysim3d · andysim3d · commit 770b6a94a7cc · 2024-03-02T23:24:36.000-05:00
Signed-off-by: Pengfei Zhang &lt;andysim3d@gmail.com&gt;
diff --git a/.gitignore b/.gitignore
@@ -7,4 +7,5 @@ dist
 .coverage
 .tox
 .*cache
-htmlcov
+htmlcov
+.vs/
diff --git a/prometheus_client/metrics.py b/prometheus_client/metrics.py
@@ -706,6 +706,8 @@ def info(self, val: Dict[str, str]) -> None:
             raise ValueError('Overlapping labels for Info metric, metric: {} child: {}'.format(
                 self._labelnames, val))
         with self._lock:
+            if any( i is None for i in val.values() ):
+                raise ValueError('Label value cannot be None')
             self._value = dict(val)
 
     def _child_samples(self) -> Iterable[Sample]:
diff --git a/tests/test_core.py b/tests/test_core.py
@@ -534,6 +534,7 @@ def test_info(self):
 
     def test_labels(self):
         self.assertRaises(ValueError, self.labels.labels('a').info, {'l': ''})
+        self.assertRaises(ValueError, self.labels.labels('a').info, {'il': None})
 
         self.labels.labels('a').info({'foo': 'bar'})
         self.assertEqual(1, self.registry.get_sample_value('il_info', {'l': 'a', 'foo': 'bar'}))

-Original file line number
+Diff line change
 .coverage
 .tox
 .*cache
 -htmlcov
 +htmlcov
 +.vs/