Skip to content

Mark collector parameter as optional in ProcessCollector and PlatformCollector #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2023
Merged

Mark collector parameter as optional in ProcessCollector and PlatformCollector #970

merged 2 commits into from
Oct 24, 2023

Conversation

albertodonato
Copy link
Contributor

The registry parameter can be passed as None, but this wasn't reflected in the typing.

@albertodonato
Mark collector parameter as optional in ProcessCollector
cfc11d8 
Signed-off-by: Alberto Donato <alberto.donato@gmail.com>
csmarchbanks
csmarchbanks approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like PlatformCollector has this issue as well, would you be interested in updating that too?

@albertodonato
Mark collector parameter as optional in PlatformCollector
0600a3d 
Signed-off-by: Alberto Donato <alberto.donato@gmail.com>
@albertodonato
Copy link
Contributor Author

Sure, done!

@albertodonato albertodonato changed the title Mark collector parameter as optional in ProcessCollector Mark collector parameter as optional in ProcessCollector and PlatformCollector Oct 24, 2023
csmarchbanks
csmarchbanks approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@csmarchbanks csmarchbanks merged commit 377e386 into prometheus:master Oct 24, 2023
@albertodonato albertodonato deleted the process-collector-param-type branch October 24, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertodonato @csmarchbanks