From e58f004cfa1b005f55ec507b5079cd71f66278df Mon Sep 17 00:00:00 2001 From: sigma-andex <77549848+sigma-andex@users.noreply.github.com> Date: Thu, 14 Apr 2022 11:50:26 +0100 Subject: [PATCH 1/4] Fix broken window export, causing the function to return itself --- src/Web/HTML.js | 2 +- src/Web/HTML.purs | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Web/HTML.js b/src/Web/HTML.js index b6254b1..5fd3c91 100644 --- a/src/Web/HTML.js +++ b/src/Web/HTML.js @@ -1,3 +1,3 @@ -export function window() { +export function windowImpl() { return window; } diff --git a/src/Web/HTML.purs b/src/Web/HTML.purs index ae31a1f..e046872 100644 --- a/src/Web/HTML.purs +++ b/src/Web/HTML.purs @@ -74,4 +74,7 @@ import Web.HTML.Location (Location) as Exports import Web.HTML.Navigator (Navigator) as Exports import Web.HTML.Window (Window) as Exports -foreign import window :: Effect Window +foreign import windowImpl :: Effect Window + +window :: Effect Window +window = windowImpl From a2c81346ffe6b1ff3bf4e22495bc9c6e6212635c Mon Sep 17 00:00:00 2001 From: sigma-andex <77549848+sigma-andex@users.noreply.github.com> Date: Thu, 14 Apr 2022 13:34:12 +0100 Subject: [PATCH 2/4] Fix pr comments --- src/Web/HTML.js | 3 ++- src/Web/HTML.purs | 5 +---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Web/HTML.js b/src/Web/HTML.js index 5fd3c91..7b0a405 100644 --- a/src/Web/HTML.js +++ b/src/Web/HTML.js @@ -1,3 +1,4 @@ -export function windowImpl() { +const windowImpl = function() { return window; } +export {windowImpl as window}; diff --git a/src/Web/HTML.purs b/src/Web/HTML.purs index e046872..ae31a1f 100644 --- a/src/Web/HTML.purs +++ b/src/Web/HTML.purs @@ -74,7 +74,4 @@ import Web.HTML.Location (Location) as Exports import Web.HTML.Navigator (Navigator) as Exports import Web.HTML.Window (Window) as Exports -foreign import windowImpl :: Effect Window - -window :: Effect Window -window = windowImpl +foreign import window :: Effect Window From f50823521b26b9bc75ecd084163ea015bdc5d537 Mon Sep 17 00:00:00 2001 From: sigma-andex <77549848+sigma-andex@users.noreply.github.com> Date: Thu, 14 Apr 2022 13:35:02 +0100 Subject: [PATCH 3/4] Format HTML.js --- src/Web/HTML.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Web/HTML.js b/src/Web/HTML.js index 7b0a405..f1cc68a 100644 --- a/src/Web/HTML.js +++ b/src/Web/HTML.js @@ -1,4 +1,4 @@ -const windowImpl = function() { - return window; +const windowImpl = function () { + return window } -export {windowImpl as window}; +export { windowImpl as window } From 368beca0ebfe29241a6e9a84007e9e5c7dd4c598 Mon Sep 17 00:00:00 2001 From: sigma-andex <77549848+sigma-andex@users.noreply.github.com> Date: Thu, 14 Apr 2022 13:37:33 +0100 Subject: [PATCH 4/4] Add semicolons --- src/Web/HTML.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Web/HTML.js b/src/Web/HTML.js index f1cc68a..de9264c 100644 --- a/src/Web/HTML.js +++ b/src/Web/HTML.js @@ -1,4 +1,4 @@ const windowImpl = function () { - return window -} -export { windowImpl as window } + return window; +}; +export { windowImpl as window };