Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

Round to the nearest float with the correct least significant decimal. #114

Open
stroobandt opened this issue Dec 25, 2017 · 1 comment
Open

Round to the nearest float with the correct least significant decimal. #114

stroobandt opened this issue Dec 25, 2017 · 1 comment

Comments

@stroobandt
Copy link

You have all been very naughty!
Look at the following Christmas bug Santa has brought…

The problem concerns the builtin function round().
In its current implementation, rounding is done to the nearest float that can be represented by the machine.
This is wrong, rounding should be done to the nearest float with the correct least significant decimal that can be represented by the machine.

Consider the following little main.py script:

f = 1011.640071
print('\n%f = float' % f)
print('%f = float rounded to one decimal' % round(f, 1))
print('%6.1f = formatted rounded float\n' % round(f, 1))

delta = 0.000040
print('%f = float correctly rounded to least significant first decimal' % (round(f, 1) + delta))
print('%6.1f = formatted correctly rounded float\n' % (round(f, 1) + delta))

epsilon = abs(7./3 - 4./3 - 1)
print('%f = 1000 × machine epsilon' % (1000 * epsilon))
print(epsilon)
print()

Here is the output on a PyBoard:

MicroPython v1.9.2-87-gda8c4c26 on 2017-09-13; PYBv1.1 with STM32F405RG

1011.639952 = float
1011.599898 = float rounded to one decimal
1011.5 = formatted rounded float

1011.600017 = float correctly rounded to least significant first decimal
1011.6 = formatted correctly rounded float

0.000119 = 1000 × machine epsilon
1.192093e-07

Things are not any different on a Pycom LoPy ESP32:

MicroPython 2ac6da2 on 2017-12-18; LoPy with ESP32

1011.639952 = float
1011.599898 = float rounded to one decimal
1011.5 = formatted rounded float

1011.600017 = float correctly rounded to least significant first decimal
1011.6 = formatted correctly rounded float

0.000119 = 1000 × machine epsilon
1.192093e-07

Note that the difference between correct and erroneous rounding is about a 1000 times the machine epsilon, which makes sense.

For certain applications, such poor rounding can have very serious consequences down the line…

This finding may account for the multitude of other reports complaining about round() behaviour:
@stroobandt
Copy link
Author

Here is a workaround:

>>> f = 1011.639952
>>> print('%f' % (round(f,1)))
1011.599898
>>> print('%s' % (repr(round(f,1))))
1011.6

However, there are still issues. More details here.

peter-pycom added a commit that referenced this issue May 4, 2020
@peter-pycom
Merge pull request #114 from pycom/lte_psm_three
684d948 
LTE: Add API for Power Saving Mode
X-Ryl669 pushed a commit to X-Ryl669/pycom-micropython-sigfox that referenced this issue May 12, 2023
@peter-pycom
Merge pull request pycom#114 from pycom/lte_psm_three
c02f2a1 
LTE: Add API for Power Saving Mode
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stroobandt