Skip to content

Support building and using with PyPy #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yuvalbar
Copy link

@yuvalbar yuvalbar commented Nov 13, 2017

This PR allows PyMSSQL to compile on PyPy. It is based on this PR: #309. I rebased the branch on the current master and made the changes requested in the linked PR to ensure it compiles properly.

@yuvalbar yuvalbar added this to the 2.1.4 milestone Nov 13, 2017
@yuvalbar yuvalbar requested a review from rsyring November 13, 2017 22:06
@yuvalbar yuvalbar mentioned this pull request Nov 13, 2017
@rsyring
Copy link
Contributor

rsyring commented Nov 13, 2017

Does this mean we can close #309?

@yuvalbar
Copy link
Author

yuvalbar commented Jan 23, 2018

@rsyring It looks like the PyPy builds are failing on a real issue with the C/Cython code which I don't yet understand. Would be good to have another person look at it.

@rsyring
Copy link
Contributor

rsyring commented Jan 23, 2018

@yuvalbar I'm sorry I can't help much. I'm a good Python dev, but if you are delving into C/Cython/PyPI compatibility, I just don't have the recent experience there to be of much help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants