Skip to content

Add media module tests #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 20, 2025
Merged

Conversation

danyeaw
Copy link
Collaborator

@danyeaw danyeaw commented Feb 28, 2025

Description

This PR fixes a portion of #2294 by adding Python and JavaScript tests for the media module.

Changes

  • Javascript add some basic functionality tests to ensure that list_devices() exists and returns a list, and that a device has the expected attributes
  • Python tests to end-to-end test the device enumeration, video stream acquisition, and adding custom constraints

Checklist

  • I have checked make build works locally.
  • I have created / updated documentation for this change (if applicable).

Copy link
Contributor

@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, thank you!

@WebReflection WebReflection merged commit b911ea9 into pyscript:main Mar 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants