Skip to content

Only clicking the Results row show the log information #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snackattas opened this issue Apr 13, 2023 · 8 comments
Open

Only clicking the Results row show the log information #653

snackattas opened this issue Apr 13, 2023 · 8 comments

Comments

@snackattas
Copy link

This is more of an enhancement, but, it would be a huge improvement to the UI

Right now, the only thing you can click to show/expand the logs is the Results row. However, the Results row is kind of small. This report would be much easier to use if any of the rows, when clicked, showed/expanded the logs.

How can I make this happen?

@BeyondEvil
Copy link
Contributor

I'm not sure I follow.

When you say "any of the rows" do you mean "any of the cells" for a particular row?

One row == one test (not entirely true as setup/teardown can get their own rows).

Regardless, please try 4.0.0rc4.

We've changed so that instead of only the "show/hide" text being clickable, the entire Results cell is now clickable.

@snackattas
Copy link
Author

When you say "any of the rows" do you mean "any of the cells" for a particular row?

Exactly. Right now only clicking the Results cell expands the logs...but my opinion is, it would be better UI if ANY of the cells (except the links) expanded the logs, even clicking the test name or the duration

@BeyondEvil
Copy link
Contributor

When you say "any of the rows" do you mean "any of the cells" for a particular row?

Exactly. Right now only clicking the Results cell expands the logs...but my opinion is, it would be better UI if ANY of the cells (except the links) expanded the logs, even clicking the test name or the duration

Cool, I'll see if it's an easy add. If it is - I'll add it to RC5.

@BeyondEvil
Copy link
Contributor

I think this is what you're after: #656

Now all cells (incl. user added, excl. Links) will be clickable to expand/collapse the row.

@snackattas
Copy link
Author

Thanks @BeyondEvil ! How would I pull in that PR to my test suite with pytest-html, is it on pypi?

@BeyondEvil
Copy link
Contributor

@snackattas
Copy link
Author

I use pipenv so github installs aren't supported, need to grab it from a release unfortunately

@BeyondEvil
Copy link
Contributor

I use pipenv so github installs aren't supported, need to grab it from a release unfortunately

You should be able to do: pipenv install -e git+<your/target/git/repository/url.git>@branch#egg=package_name

If not, you can do pipenv run pip install ....

or

pipenv shell and then pip install ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants