Skip to content

Add "first contribution" label #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mariatta opened this issue Apr 30, 2021 · 7 comments
Closed

Add "first contribution" label #397

Mariatta opened this issue Apr 30, 2021 · 7 comments
Labels
labels Issues related to GitHub label changes

Comments

@Mariatta
Copy link
Member

GitHub announced a recent change where maintainers need to "approve" workflow runs for PRs from first-time contributors.

Article: https://github.blog/changelog/2021-04-22-github-actions-maintainers-must-approve-first-time-contributor-workflow-runs/

Basically, before the CI would run on the PR, core devs need to first "approve" the workflow run, and just the workflow, not the whole PR. I have just came across this in one of the PR in CPython today.

Screenshot from GitHub article. https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

image

One of the issue is that we can't easily tell (visually) of PRs from first time contributors until we open the PR itself. It is not shown in the list of PRs web UI.

Suggestion

I think we need to add a "first contribution" label to PRs from first time contributors.
Then we need to make the bot apply such label to the PR opened by first time contributors. There is a "membership" data that gets passed in the webhooks payload.

Perhaps there's an existing GH action that does this already? If not, it is easy to add to bedevere.

questions

  • What color do we want this label to be?
  • If writing our own automation, do we do this in bedevere, or GH action?
@Mariatta
Copy link
Member Author

Screenshot from python/cpython#25702

It looks like only GitHub Action workflows are blocked and needing review. 🤔
Screenshot_20210430-092143

@terryjreedy
Copy link
Member

terryjreedy commented Apr 30, 2021 •
edited
Loading

Who makes label: whatever is easier to do and maintain?

Color: the 'awaiting' orange, similar to 'caution' road signs, or something close.

One GHA: ask GH about this. They only care abut their resources? Anyway, we would not want to have separate buttons for other CI providers.

There should be a 2nd button choice: (Close as 'invalid') (or 'spam') to add label and notify GH to ding rep of submitter.

@brettcannon
Copy link
Member

There's a bunch of GitHub Actions we can either pick from or get inspiration for: https://github.com/marketplace?type=actions&query=first+pull+request

@Mariatta
Copy link
Member Author

Would we still be able to apply label via GitHub Actions this way, now that the workflows aren't being run for the first time contributors? Seems like we have no choice but implement this in bedevere?

@brettcannon
Copy link
Member

Except Bedevere is supposed to be moving to GitHub Actions for easier maintenance.

@Safihre
Copy link

Safihre commented Mar 15, 2022

Can I suggest to change the setting to only require approval for new GitHub accounts and not for all first-time contributors?
That was added a few months ago by GitHub.

image

@ezio-melotti ezio-melotti added the labels Issues related to GitHub label changes label Jun 5, 2022
@ezio-melotti
Copy link
Member

I changed the setting to Require approval for first-time contributors who are new to GitHub, so I'm going to close this issue. If you think it needs further discussion or a different solution, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
labels Issues related to GitHub label changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brettcannon @Safihre @Mariatta @terryjreedy @ezio-melotti