Fix-up parenthesis, organization, and NULL check (GH-9297)

rhettinger · web-flow · commit 00bc08ec11d9 · 2018-09-14T01:00:11.000-07:00
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -5280,14 +5280,19 @@ static PyObject *
 int_as_integer_ratio_impl(PyObject *self)
 /*[clinic end generated code: output=e60803ae1cc8621a input=55ce3058e15de393]*/
 {
-    if PyLong_CheckExact(self) {
+    PyObject *numerator;
+    PyObject *ratio_tuple;
+
+    if (PyLong_CheckExact(self)) {
         return PyTuple_Pack(2, self, _PyLong_One);
-    } else {
-        PyObject *numerator = _PyLong_Copy(self);
-        PyObject *ratio_tuple = PyTuple_Pack(2, numerator, _PyLong_One);
-        Py_DECREF(numerator);
-        return ratio_tuple;
     }
+    numerator = _PyLong_Copy(self);
+    if (numerator == NULL) {
+        return NULL;
+    }
+    ratio_tuple = PyTuple_Pack(2, numerator, _PyLong_One);
+    Py_DECREF(numerator);
+    return ratio_tuple;
 }
 
 /*[clinic input]
