Update Include/internal/pycore_critical_section.h

MojoVampire · colesbury · MojoVampire · commit 0475c8eb4102 · 2024-05-22T16:09:28.000Z
Use braces to restrict scope of conditional locking

Co-authored-by: Sam Gross &lt;colesbury@gmail.com&gt;
diff --git a/Include/internal/pycore_critical_section.h b/Include/internal/pycore_critical_section.h
@@ -124,8 +124,9 @@ extern "C" {
                                      &_orig_seq->ob_mutex)  \
 
 # define Py_END_CRITICAL_SECTION_SEQUENCE_FAST()                        \
-        if (_should_lock_cs)                                            \
+        if (_should_lock_cs) {                                          \
             _PyCriticalSection_End(&_cs);                               \
+        }                                                               \
     }
 
 // Asserts that the mutex is locked.  The mutex must be held by the

Original file line number	Diff line number	Diff line change
`@@ -124,8 +124,9 @@ extern "C" {`
`124`	`124`	`&_orig_seq->ob_mutex) \`
`125`	`125`
`126`	`126`	`# define Py_END_CRITICAL_SECTION_SEQUENCE_FAST() \`
`127`		`- if (_should_lock_cs) \`
	`127`	`+ if (_should_lock_cs) { \`
`128`	`128`	`_PyCriticalSection_End(&_cs); \`
	`129`	`+ } \`
`129`	`130`	`}`
`130`	`131`
`131`	`132`	`// Asserts that the mutex is locked. The mutex must be held by the`