[3.12] gh-126341: add release check to __iter__ method of memoryview (GH-126759) (#126779)

miss-islington · ritvikpasham · blurb-it[bot] · web-flow · commit 0bdcc84ae99f · 2024-11-13T20:44:01.000+02:00
gh-126341: add release check to `__iter__` method of `memoryview` (GH-126759) (cherry picked from commit a12690e) Co-authored-by: Ritvik Pasham <ritvikpasham@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: sobolevn <mail@sobolevn.me>
diff --git a/Lib/test/test_buffer.py b/Lib/test/test_buffer.py
@@ -3906,6 +3906,8 @@ def test_memoryview_check_released(self):
         self.assertRaises(ValueError, memoryview, m)
         # memoryview.cast()
         self.assertRaises(ValueError, m.cast, 'c')
+        # memoryview.__iter__()
+        self.assertRaises(ValueError, m.__iter__)
         # getbuffer()
         self.assertRaises(ValueError, ndarray, m)
         # memoryview.tolist()
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2024-11-12-19-24-00.gh-issue-126341.5SdAe1.rst b/Misc/NEWS.d/next/Core_and_Builtins/2024-11-12-19-24-00.gh-issue-126341.5SdAe1.rst
@@ -0,0 +1 @@
+Now :exc:`ValueError` is raised instead of :exc:`SystemError` when trying to iterate over a released :class:`memoryview` object.
diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c
@@ -3322,6 +3322,7 @@ memory_iter(PyObject *seq)
         PyErr_BadInternalCall();
         return NULL;
     }
+    CHECK_RELEASED(seq);
     PyMemoryViewObject *obj = (PyMemoryViewObject *)seq;
     int ndims = obj->view.ndim;
     if (ndims == 0) {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Now :exc:`ValueError` is raised instead of :exc:`SystemError` when trying to iterate over a released :class:`memoryview` object.
Original file line number	Diff line number	Diff line change
`@@ -3322,6 +3322,7 @@ memory_iter(PyObject *seq)`
`3322`	`3322`	`PyErr_BadInternalCall();`
`3323`	`3323`	`return NULL;`
`3324`	`3324`	`}`
	`3325`	`+ CHECK_RELEASED(seq);`
`3325`	`3326`	`PyMemoryViewObject obj = (PyMemoryViewObject )seq;`
`3326`	`3327`	`int ndims = obj->view.ndim;`
`3327`	`3328`	`if (ndims == 0) {`