[3.14] gh-132983: Fix refleak in zstd dictionary functions (gh-134463)

miss-islington · emmatyping · web-flow · commit 11d77d21120b · 2025-05-21T19:35:31.000Z
(cherry picked from commit fb68776, AKA gh-134459) Co-authored-by: Emma Smith <emma@emmatyping.dev>
diff --git a/Modules/_zstd/_zstdmodule.c b/Modules/_zstd/_zstdmodule.c
@@ -251,7 +251,7 @@ _zstd_train_dict_impl(PyObject *module, PyBytesObject *samples_bytes,
                                             &chunk_sizes);
     if (chunks_number < 0)
     {
-        return NULL;
+        goto error;
     }
 
     /* Allocate dict buffer */
@@ -333,7 +333,7 @@ _zstd_finalize_dict_impl(PyObject *module, PyBytesObject *custom_dict_bytes,
                                             &chunk_sizes);
     if (chunks_number < 0)
     {
-        return NULL;
+        goto error;
     }
 
     /* Allocate dict buffer */

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ _zstd_train_dict_impl(PyObject module, PyBytesObject samples_bytes,`
`251`	`251`	`&chunk_sizes);`
`252`	`252`	`if (chunks_number < 0)`
`253`	`253`	`{`
`254`		`- return NULL;`
	`254`	`+ goto error;`
`255`	`255`	`}`
`256`	`256`
`257`	`257`	`/* Allocate dict buffer */`
`@@ -333,7 +333,7 @@ _zstd_finalize_dict_impl(PyObject module, PyBytesObject custom_dict_bytes,`
`333`	`333`	`&chunk_sizes);`
`334`	`334`	`if (chunks_number < 0)`
`335`	`335`	`{`
`336`		`- return NULL;`
	`336`	`+ goto error;`
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`/* Allocate dict buffer */`