Rename to PyInitConfig_SetStringList()

vstinner · vstinner · commit 26ff1c2a6495 · 2023-10-01T14:29:38.000+02:00
diff --git a/Include/initconfig.h b/Include/initconfig.h
@@ -9,6 +9,9 @@ typedef struct PyInitConfig PyInitConfig;
 // Create a new initialization configuration.
 // It must be freed by PyInitConfig_Free().
 // Return NULL on memory allocation failure.
+//
+// PyInitConfig_Python_New() has a Python configuration by default.
+// PyInitConfig_Isolated_New() has an Isolated configuration by default.
 PyAPI_FUNC(PyInitConfig*) PyInitConfig_Python_New(void);
 PyAPI_FUNC(PyInitConfig*) PyInitConfig_Isolated_New(void);
 
@@ -31,7 +34,7 @@ PyAPI_FUNC(int) PyInitConfig_SetString(
 
 // Set a string configuration option.
 // Return 0 on success, or return -1 on error.
-PyAPI_FUNC(int) PyInitConfig_SetList(
+PyAPI_FUNC(int) PyInitConfig_SetStringList(
     PyInitConfig *config,
     const char *key,
     size_t length,
diff --git a/Programs/_testembed.c b/Programs/_testembed.c
@@ -1742,7 +1742,7 @@ static int test_initconfig_api(void)
     }
 
     wchar_t *argv[] = {PROGRAM_NAME, L"-c", L"pass"};
-    if (PyInitConfig_SetList(config, "argv", Py_ARRAY_LENGTH(argv), argv) < 0) {
+    if (PyInitConfig_SetStringList(config, "argv", Py_ARRAY_LENGTH(argv), argv) < 0) {
         goto error;
     }
 
diff --git a/Python/initconfig.c b/Python/initconfig.c
@@ -3289,8 +3289,8 @@ PyInitConfig_SetString(PyInitConfig *config, const char *key,
 }
 
 int
-PyInitConfig_SetList(PyInitConfig *config, const char *key,
-                     size_t length, wchar_t **items)
+PyInitConfig_SetStringList(PyInitConfig *config, const char *key,
+                           size_t length, wchar_t **items)
 {
     const PyConfigSpec *spec = initconfig_prepare_set(config, key);
     if (spec == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -1742,7 +1742,7 @@ static int test_initconfig_api(void)`
`1742`	`1742`	`}`
`1743`	`1743`
`1744`	`1744`	`wchar_t *argv[] = {PROGRAM_NAME, L"-c", L"pass"};`
`1745`		`- if (PyInitConfig_SetList(config, "argv", Py_ARRAY_LENGTH(argv), argv) < 0) {`
	`1745`	`+ if (PyInitConfig_SetStringList(config, "argv", Py_ARRAY_LENGTH(argv), argv) < 0) {`
`1746`	`1746`	`goto error;`
`1747`	`1747`	`}`
`1748`	`1748`
Original file line number	Diff line number	Diff line change
`@@ -3289,8 +3289,8 @@ PyInitConfig_SetString(PyInitConfig config, const char key,`
`3289`	`3289`	`}`
`3290`	`3290`
`3291`	`3291`	`int`
`3292`		`-PyInitConfig_SetList(PyInitConfig config, const char key,`
`3293`		`- size_t length, wchar_t **items)`
	`3292`	`+PyInitConfig_SetStringList(PyInitConfig config, const char key,`
	`3293`	`+ size_t length, wchar_t **items)`
`3294`	`3294`	`{`
`3295`	`3295`	`const PyConfigSpec *spec = initconfig_prepare_set(config, key);`
`3296`	`3296`	`if (spec == NULL) {`