[3.10] gh-119690: Fixes buffer type confusion in _winapi.CreateFile and _winapi.CreateNamedPipe audit events (#119735)

zooba · web-flow · commit 2e861ac1cd43 · 2024-09-04T17:57:40.000+02:00
gh-119690: Fixes buffer type confusion in _winapi.CreateFile and _winapi.CreateNamedPipe audit events
diff --git a/Misc/NEWS.d/next/Windows/2024-05-29-17-05-28.gh-issue-119690.U6RMtm.rst b/Misc/NEWS.d/next/Windows/2024-05-29-17-05-28.gh-issue-119690.U6RMtm.rst
@@ -0,0 +1,2 @@
+Fixes data type confusion in audit events raised by ``_winapi.CreateFile``
+and ``_winapi.CreateNamedPipe``.
diff --git a/Modules/_winapi.c b/Modules/_winapi.c
@@ -470,7 +470,7 @@ _winapi_CreateFile_impl(PyObject *module, LPCTSTR file_name,
 {
     HANDLE handle;
 
-    if (PySys_Audit("_winapi.CreateFile", "uIIII",
+    if (PySys_Audit("_winapi.CreateFile", "sIIII",
                     file_name, desired_access, share_mode,
                     creation_disposition, flags_and_attributes) < 0) {
         return INVALID_HANDLE_VALUE;
@@ -690,7 +690,7 @@ _winapi_CreateNamedPipe_impl(PyObject *module, LPCTSTR name, DWORD open_mode,
 {
     HANDLE handle;
 
-    if (PySys_Audit("_winapi.CreateNamedPipe", "uII",
+    if (PySys_Audit("_winapi.CreateNamedPipe", "sII",
                     name, open_mode, pipe_mode) < 0) {
         return INVALID_HANDLE_VALUE;
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fixes data type confusion in audit events raised by ``_winapi.CreateFile``
	`2`	+and ``_winapi.CreateNamedPipe``.
Original file line number	Diff line number	Diff line change
`@@ -470,7 +470,7 @@ _winapi_CreateFile_impl(PyObject *module, LPCTSTR file_name,`
`470`	`470`	`{`
`471`	`471`	`HANDLE handle;`
`472`	`472`
`473`		`- if (PySys_Audit("_winapi.CreateFile", "uIIII",`
	`473`	`+ if (PySys_Audit("_winapi.CreateFile", "sIIII",`
`474`	`474`	`file_name, desired_access, share_mode,`
`475`	`475`	`creation_disposition, flags_and_attributes) < 0) {`
`476`	`476`	`return INVALID_HANDLE_VALUE;`
`@@ -690,7 +690,7 @@ _winapi_CreateNamedPipe_impl(PyObject *module, LPCTSTR name, DWORD open_mode,`
`690`	`690`	`{`
`691`	`691`	`HANDLE handle;`
`692`	`692`
`693`		`- if (PySys_Audit("_winapi.CreateNamedPipe", "uII",`
	`693`	`+ if (PySys_Audit("_winapi.CreateNamedPipe", "sII",`
`694`	`694`	`name, open_mode, pipe_mode) < 0) {`
`695`	`695`	`return INVALID_HANDLE_VALUE;`
`696`	`696`	`}`