Fix race condition in the test case (for real this time).

ZeroIntensity · ZeroIntensity · commit 38e29f9ccde2 · 2025-08-09T12:25:50.000-04:00
Apparently, the thread can start waiting at a point where the server
isn't ready to receive messages, which caused it to block indefinitely
for some reason. Before we create any threads or set any events, do a
simple exchange with the server to ensure that it's in its message loop.
This took way too damn long to figure out.
diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py
@@ -4628,11 +4628,11 @@ def test_thread_recv_while_main_thread_sends(self):
         # if a thread started to infinitely block until data was received, calls
         # to send() would deadlock, because it would wait forever on the lock
         # that the recv() call held.
-        data = b"1" * 50
+        data = b"1" * 1024
         event = threading.Event()
         def background(sock):
             event.set()
-            received = sock.recv(50)
+            received = sock.recv(len(data))
             self.assertEqual(received, data)
 
         client_context, server_context, hostname = testing_context()
@@ -4641,16 +4641,16 @@ def background(sock):
             with client_context.wrap_socket(socket.socket(),
                                             server_hostname=hostname) as sock:
                 sock.connect((HOST, server.port))
-                sock.settimeout(5)
+                sock.settimeout(1)
+                # Ensure that the server is ready to accept requests
+                sock.sendall(b"123")
+                self.assertEqual(sock.recv(3), b"123")
                 with threading_helper.catch_threading_exception() as cm:
                     thread = threading.Thread(target=background,
                                               args=(sock,), daemon=True)
                     thread.start()
                     event.wait()
-                    # We need to yield the GIL to prevent some silly race
-                    # condition in ThreadedEchoServer
-                    time.sleep(0)
-                    sock.sendall(b"1" * 50)
+                    sock.sendall(data)
                     thread.join()
                     if cm.exc_value is not None:
                         raise cm.exc_value
