gh-116267: Do not check record size in RotatingFileHandler to avoid formatting twice

Jason-Y-Z · Jason-Y-Z · commit 4d243577cde8 · 2024-03-04T21:42:13.000Z
diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
@@ -180,22 +180,19 @@ def doRollover(self):
         if not self.delay:
             self.stream = self._open()
 
-    def shouldRollover(self, record):
+    def shouldRollover(self, _):
         """
-        Determine if rollover should occur.
-
-        Basically, see if the supplied record would cause the file to exceed
-        the size limit we have.
+        Determine if the file has exceeded the size limit we have,
+        and therefore we should roll over.
         """
         # See bpo-45401: Never rollover anything other than regular files
         if os.path.exists(self.baseFilename) and not os.path.isfile(self.baseFilename):
             return False
         if self.stream is None:                 # delay was set...
             self.stream = self._open()
         if self.maxBytes > 0:                   # are we rolling over?
-            msg = "%s\n" % self.format(record)
             self.stream.seek(0, 2)  #due to non-posix-compliant Windows feature
-            if self.stream.tell() + len(msg) >= self.maxBytes:
+            if self.stream.tell() >= self.maxBytes:
                 return True
         return False
 
