bpo-38806: bdb: stop_here: always stop at calling frame

blueyed · blueyed · commit 561d3c129921 · 2021-09-18T10:26:33.000+02:00
The following will not stop for debugging: python3.8 -c 'import pdb; pdb.Pdb(skip=["*"]).set_trace()' The example is contrived, the real case would be to have some "noisy" module being excluded in general, but when you add an explicit "set_trace()" in there it should still stop there, and not on some upper frame. This was changed a long time already in 313a751 (Python 2.3), but it is not really clear. This PR is meant to see how reverting that part goes.
diff --git a/Lib/bdb.py b/Lib/bdb.py
@@ -201,8 +201,8 @@ def is_skipped_module(self, module_name):
 
     def stop_here(self, frame):
         "Return True if frame is below the starting frame in the stack."
-        # (CT) stopframe may now also be None, see dispatch_call.
-        # (CT) the former test for None is therefore removed from here.
+        if self.stopframe is None:
+            return True
         if self.skip and \
                self.is_skipped_module(frame.f_globals.get('__name__')):
             return False
