Avoid decrefs by moving state lookup earlier in the function

rhettinger · rhettinger · commit 5a03e52d87b4 · 2021-04-21T11:30:39.000-07:00
diff --git a/Modules/_functoolsmodule.c b/Modules/_functoolsmodule.c
@@ -1159,6 +1159,11 @@ lru_cache_new(PyTypeObject *type, PyObject *args, PyObject *kw)
         return NULL;
     }
 
+    state = get_functools_state_by_type(type);
+    if (state == NULL) {
+        return NULL;
+    }
+
     /* select the caching function, and make/inc maxsize_O */
     if (maxsize_O == Py_None) {
         wrapper = infinite_lru_cache_wrapper;
@@ -1189,13 +1194,6 @@ lru_cache_new(PyTypeObject *type, PyObject *args, PyObject *kw)
         return NULL;
     }
 
-    state = get_functools_state_by_type(Py_TYPE(obj));
-    if (state == NULL) {
-        Py_DECREF(cachedict);
-        Py_DECREF(obj);
-        return NULL;
-    }
-
     obj->root.prev = &obj->root;
     obj->root.next = &obj->root;
     obj->wrapper = wrapper;
