Do not double-count names.

ericsnowcurrently · ericsnowcurrently · commit 5f6fe84a7889 · 2025-05-01T13:57:49.000-06:00
diff --git a/Objects/codeobject.c b/Objects/codeobject.c
@@ -1760,20 +1760,20 @@ identify_unbound_names(PyThreadState *tstate, PyCodeObject *co,
             }
             unbound.total += 1;
             unbound.globals.total += 1;
-            unbound.globals.numunknown += 1;
             if (globalsns != NULL && PyDict_Contains(globalsns, name)) {
                 if (_PyErr_Occurred(tstate)) {
                     return -1;
                 }
                 unbound.globals.numglobal += 1;
-                unbound.globals.numunknown -= 1;
             }
-            if (builtinsns != NULL && PyDict_Contains(builtinsns, name)) {
+            else if (builtinsns != NULL && PyDict_Contains(builtinsns, name)) {
                 if (_PyErr_Occurred(tstate)) {
                     return -1;
                 }
                 unbound.globals.numbuiltin += 1;
-                unbound.globals.numunknown -= 1;
+            }
+            else {
+                unbound.globals.numunknown += 1;
             }
             if (PySet_Add(globalnames, name) < 0) {
                 return -1;

Original file line number	Diff line number	Diff line change
`@@ -1760,20 +1760,20 @@ identify_unbound_names(PyThreadState tstate, PyCodeObject co,`
`1760`	`1760`	`}`
`1761`	`1761`	`unbound.total += 1;`
`1762`	`1762`	`unbound.globals.total += 1;`
`1763`		`- unbound.globals.numunknown += 1;`
`1764`	`1763`	`if (globalsns != NULL && PyDict_Contains(globalsns, name)) {`
`1765`	`1764`	`if (_PyErr_Occurred(tstate)) {`
`1766`	`1765`	`return -1;`
`1767`	`1766`	`}`
`1768`	`1767`	`unbound.globals.numglobal += 1;`
`1769`		`- unbound.globals.numunknown -= 1;`
`1770`	`1768`	`}`
`1771`		`- if (builtinsns != NULL && PyDict_Contains(builtinsns, name)) {`
	`1769`	`+ else if (builtinsns != NULL && PyDict_Contains(builtinsns, name)) {`
`1772`	`1770`	`if (_PyErr_Occurred(tstate)) {`
`1773`	`1771`	`return -1;`
`1774`	`1772`	`}`
`1775`	`1773`	`unbound.globals.numbuiltin += 1;`
`1776`		`- unbound.globals.numunknown -= 1;`
	`1774`	`+ }`
	`1775`	`+ else {`
	`1776`	`+ unbound.globals.numunknown += 1;`
`1777`	`1777`	`}`
`1778`	`1778`	`if (PySet_Add(globalnames, name) < 0) {`
`1779`	`1779`	`return -1;`