Per review, refactor extend test to extend multiple times, and reduce total time to run tests (both tests combine to less than 200 ms in debug build on my laptop)

MojoVampire · MojoVampire · commit 66f0e6ceb603 · 2024-05-22T16:09:28.000Z
diff --git a/Lib/test/test_free_threading/test_str.py b/Lib/test/test_free_threading/test_str.py
@@ -2,7 +2,7 @@
 import unittest
 
 from itertools import cycle
-from threading import Thread
+from threading import Event, Thread
 from unittest import TestCase
 
 from test.support import threading_helper
@@ -12,21 +12,20 @@ class TestStr(TestCase):
     def test_racing_join_extend(self):
         '''Test joining a string being extended by another thread'''
         l = []
-        OBJECT_COUNT = 100_000
-
+        ITERS = 100
+        READERS = 10
+        done_event = Event()
         def writer_func():
-            l.extend(map(str, range(OBJECT_COUNT, OBJECT_COUNT*2)))
-
+            for i in range(ITERS):
+                l.extend(map(str, range(i)))
+                l.clear()
+            done_event.set()
         def reader_func():
-            while True:
-                count = len(l)
+            while not done_event.is_set():
                 ''.join(l)
-                if count == OBJECT_COUNT:
-                    break
-
         writer = Thread(target=writer_func)
         readers = []
-        for x in range(30):
+        for x in range(READERS):
             reader = Thread(target=reader_func)
             readers.append(reader)
             reader.start()
@@ -42,7 +41,8 @@ def test_racing_join_replace(self):
         strings by another thread.
         '''
         l = [*'abcdefg']
-        MAX_ORDINAL = 10_000
+        MAX_ORDINAL = 1_000
+        READERS = 20
 
         def writer_func():
             for i, c in zip(cycle(range(len(l))),
@@ -59,7 +59,7 @@ def reader_func():
 
         writer = Thread(target=writer_func)
         readers = []
-        for x in range(30):
+        for x in range(READERS):
             reader = Thread(target=reader_func)
             readers.append(reader)
             reader.start()
