bpo-40469: Make TimedRotatingFileHandler use CTIME instead of MTIME

martonivan · martonivan · commit 7793f9c3c5c9 · 2024-03-01T21:12:20.000+01:00
The TimedRotatingFileHandler previously used MTIME attribute of the log
file to detect whether it has to be rotate yet or not. In cases when the
file is changed within the rotatation period the MTIME is also updated
to the current time and the rotation never happens. It's more
appropriate to check the file creation time (CTIME) instead.
diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
@@ -24,7 +24,7 @@
 """
 
 import io, logging, socket, os, pickle, struct, time, re
-from stat import ST_DEV, ST_INO, ST_MTIME
+from stat import ST_DEV, ST_INO, ST_CTIME
 import queue
 import threading
 import copy
@@ -263,7 +263,7 @@ def __init__(self, filename, when='h', interval=1, backupCount=0,
         # path object (see Issue #27493), but self.baseFilename will be a string
         filename = self.baseFilename
         if os.path.exists(filename):
-            t = os.stat(filename)[ST_MTIME]
+            t = os.stat(filename)[ST_CTIME]
         else:
             t = int(time.time())
         self.rolloverAt = self.computeRollover(t)
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -1170,6 +1170,7 @@ Owen Martin
 Sidney San Martín
 Westley Martínez
 Sébastien Martini
+Iván Márton
 Roger Masse
 Nick Mathewson
 Simon Mathieu
