gh-95041: fail syslog.syslog in case inner call to syslog.openlog fails

noamcohen97 · noamcohen97 · commit 8210ab33c192 · 2022-07-26T09:51:53.000+03:00
diff --git a/Modules/syslogmodule.c b/Modules/syslogmodule.c
@@ -191,8 +191,11 @@ syslog_syslog(PyObject * self, PyObject * args)
          */
         if ((openargs = PyTuple_New(0))) {
             PyObject *openlog_ret = syslog_openlog(self, openargs, NULL);
-            Py_XDECREF(openlog_ret);
             Py_DECREF(openargs);
+            Py_XDECREF(openlog_ret);
+            if (openlog_ret == NULL) {
+                return NULL;
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -191,8 +191,11 @@ syslog_syslog(PyObject * self, PyObject * args)`
`191`	`191`	`*/`
`192`	`192`	`if ((openargs = PyTuple_New(0))) {`
`193`	`193`	`PyObject *openlog_ret = syslog_openlog(self, openargs, NULL);`
`194`		`- Py_XDECREF(openlog_ret);`
`195`	`194`	`Py_DECREF(openargs);`
	`195`	`+ Py_XDECREF(openlog_ret);`
	`196`	`+ if (openlog_ret == NULL) {`
	`197`	`+ return NULL;`
	`198`	`+ }`
`196`	`199`	`}`
`197`	`200`	`}`
`198`	`201`