gh-111342: fix typo in math.sumprod (GH-111416)

skirpichev · web-flow · commit 9dc4fb820439 · 2023-10-27T23:52:04.000-05:00
diff --git a/Lib/test/test_math.py b/Lib/test/test_math.py
@@ -1325,6 +1325,7 @@ def test_sumprod_accuracy(self):
         sumprod = math.sumprod
         self.assertEqual(sumprod([0.1] * 10, [1]*10), 1.0)
         self.assertEqual(sumprod([0.1] * 20, [True, False] * 10), 1.0)
+        self.assertEqual(sumprod([True, False] * 10, [0.1] * 20), 1.0)
         self.assertEqual(sumprod([1.0, 10E100, 1.0, -10E100], [1.0]*4), 2.0)
 
     @support.requires_resource('cpu')
diff --git a/Misc/NEWS.d/next/Library/2023-10-28-04-21-17.gh-issue-111342.m8Ln1k.rst b/Misc/NEWS.d/next/Library/2023-10-28-04-21-17.gh-issue-111342.m8Ln1k.rst
@@ -0,0 +1 @@
+Fixed typo in :func:`math.sumprod`.
diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
@@ -2832,7 +2832,7 @@ math_sumprod_impl(PyObject *module, PyObject *p, PyObject *q)
                         PyErr_Clear();
                         goto finalize_flt_path;
                     }
-                } else if (q_type_float && (PyLong_CheckExact(p_i) || PyBool_Check(q_i))) {
+                } else if (q_type_float && (PyLong_CheckExact(p_i) || PyBool_Check(p_i))) {
                     flt_q = PyFloat_AS_DOUBLE(q_i);
                     flt_p = PyLong_AsDouble(p_i);
                     if (flt_p == -1.0 && PyErr_Occurred()) {

Original file line number	Diff line number	Diff line change
`@@ -2832,7 +2832,7 @@ math_sumprod_impl(PyObject module, PyObject p, PyObject *q)`
`2832`	`2832`	`PyErr_Clear();`
`2833`	`2833`	`goto finalize_flt_path;`
`2834`	`2834`	`}`
`2835`		`- } else if (q_type_float && (PyLong_CheckExact(p_i) \|\| PyBool_Check(q_i))) {`
	`2835`	`+ } else if (q_type_float && (PyLong_CheckExact(p_i) \|\| PyBool_Check(p_i))) {`
`2836`	`2836`	`flt_q = PyFloat_AS_DOUBLE(q_i);`
`2837`	`2837`	`flt_p = PyLong_AsDouble(p_i);`
`2838`	`2838`	`if (flt_p == -1.0 && PyErr_Occurred()) {`