bpo-31620: have asyncio/queues not leak memory when you've exceptions during waiting (GH-3813) (#4326)

miss-islington · asvetlov · commit ac4f6d4448fb · 2017-11-07T22:08:15.000+03:00
(cherry picked from commit c62f0cb)
diff --git a/Lib/asyncio/queues.py b/Lib/asyncio/queues.py
@@ -167,6 +167,12 @@ def get(self):
                 yield from getter
             except:
                 getter.cancel()  # Just in case getter is not done yet.
+
+                try:
+                    self._getters.remove(getter)
+                except ValueError:
+                    pass
+
                 if not self.empty() and not getter.cancelled():
                     # We were woken up by put_nowait(), but can't take
                     # the call.  Wake up the next in line.
diff --git a/Lib/test/test_asyncio/test_queues.py b/Lib/test/test_asyncio/test_queues.py
@@ -295,6 +295,23 @@ def producer(queue, num_items):
                            loop=self.loop),
             )
 
+    def test_cancelled_getters_not_being_held_in_self_getters(self):
+        def a_generator():
+            yield 0.1
+            yield 0.2
+
+        self.loop = self.new_test_loop(a_generator)
+        @asyncio.coroutine
+        def consumer(queue):
+            try:
+                item = yield from asyncio.wait_for(queue.get(), 0.1, loop=self.loop)
+            except asyncio.TimeoutError:
+                pass
+
+        queue = asyncio.Queue(loop=self.loop, maxsize=5)
+        self.loop.run_until_complete(self.loop.create_task(consumer(queue)))
+        self.assertEqual(len(queue._getters), 0)
+
 
 class QueuePutTests(_QueueTestBase):
 
diff --git a/Misc/NEWS.d/next/Library/2017-10-06-04-35-31.bpo-31620.gksLA1.rst b/Misc/NEWS.d/next/Library/2017-10-06-04-35-31.bpo-31620.gksLA1.rst
@@ -0,0 +1,2 @@
+an empty asyncio.Queue now doesn't leak memory when queue.get pollers
+timeout

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+an empty asyncio.Queue now doesn't leak memory when queue.get pollers`
	`2`	`+timeout`