gh-106045: Fix venv creation from a python executable symlink

mayeut · mayeut · commit ad36335be1f4 · 2024-05-11T19:03:43.000+02:00
diff --git a/Lib/test/test_venv.py b/Lib/test/test_venv.py
@@ -775,6 +775,29 @@ def test_venv_same_path(self):
                 else:
                     self.assertFalse(same_path(path1, path2))
 
+    @requires_subprocess()
+    @unittest.skipIf(os.name == 'nt', 'not relevant on Windows')
+    @unittest.skipUnless(can_symlink(), 'Needs symlinks')
+    def test_executable_symlink(self):
+        """
+        Test creation using a symlink to python executable.
+        """
+        rmtree(self.env_dir)
+        with tempfile.TemporaryDirectory() as symlink_dir:
+            executable_symlink = os.path.join(
+                os.path.realpath(symlink_dir),
+                os.path.basename(sys.executable))
+            os.symlink(os.path.abspath(sys.executable), executable_symlink)
+            cmd = [executable_symlink, "-m", "venv", "--without-pip",
+                   self.env_dir]
+            subprocess.check_call(cmd)
+        data = self.get_text_file_contents('pyvenv.cfg')
+        executable = sys._base_executable
+        path = os.path.dirname(executable)
+        self.assertIn('home = %s' % path, data)
+        self.assertIn('executable = %s' %
+                      os.path.realpath(sys.executable), data)
+
 @requireVenvCreate
 class EnsurePipTest(BaseTest):
     """Test venv module installation of pip."""
diff --git a/Lib/venv/__init__.py b/Lib/venv/__init__.py
@@ -164,7 +164,7 @@ def create_if_needed(d):
                              'Python interpreter. Provide an explicit path or '
                              'check that your PATH environment variable is '
                              'correctly set.')
-        dirname, exename = os.path.split(os.path.abspath(executable))
+        dirname, exename = os.path.split(os.path.realpath(executable))
         if sys.platform == 'win32':
             # Always create the simplest name in the venv. It will either be a
             # link back to executable, or a copy of the appropriate launcher
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -416,6 +416,7 @@ Eric Daniel
 Scott David Daniels
 Derzsi Dániel
 Lawrence D'Anna
+Matthieu Darbois
 Ben Darnell
 Kushal Das
 Jonathan Dasteel
diff --git a/Misc/NEWS.d/next/Library/2024-02-10-11-41-42.gh-issue-106045.eVZFt2.rst b/Misc/NEWS.d/next/Library/2024-02-10-11-41-42.gh-issue-106045.eVZFt2.rst
@@ -0,0 +1,2 @@
+Fix ``venv`` creation from a python executable symlink. Patch by Matthieu
+Darbois.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Fix ``venv`` creation from a python executable symlink. Patch by Matthieu
	`2`	`+Darbois.`