Skip to content

Commit ebf92bb

Browse files
committed
Add mismatched bracket test cases, fix news format
1 parent 3ab35e8 commit ebf92bb

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

Lib/test/test_urlparse.py

+10
Original file line numberDiff line numberDiff line change
@@ -1426,6 +1426,16 @@ def test_invalid_bracketed_hosts(self):
14261426
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://[::1].suffix?')
14271427
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://user@prefix.[v6a.ip]')
14281428
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://user@[v6a.ip].suffix')
1429+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://[v6a.ip')
1430+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://v6a.ip]')
1431+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://]v6a.ip[')
1432+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://]v6a.ip')
1433+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://v6a.ip[')
1434+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://prefix.[v6a.ip')
1435+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://v6a.ip].suffix')
1436+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://prefix]v6a.ip[suffix')
1437+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://prefix]v6a.ip')
1438+
self.assertRaises(ValueError, urllib.parse.urlsplit, 'scheme://v6a.ip[suffix')
14291439

14301440
def test_splitting_bracketed_hosts(self):
14311441
p1 = urllib.parse.urlsplit('scheme://user@[v6a.ip]/path?query')
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
When using :func:`urllib.parse.urlsplit()` and :func:`urllib.parse.urlparse()` host parsing would
2-
not reject domain names containing square brackets (``[`` and ``]``). Square
3-
brackets are only valid for IPv6 and IPvFuture hosts according to `RFC 3986
4-
Section 3.2.2 <https://www.rfc-editor.org/rfc/rfc3986#section-3.2.2>`__.
1+
When using :func:`urllib.parse.urlsplit` and :func:`urllib.parse.urlparse` host
2+
parsing would not reject domain names containing square brackets (``[`` and
3+
``]``). Square brackets are only valid for IPv6 and IPvFuture hosts according to
4+
`RFC 3986 Section 3.2.2 <https://www.rfc-editor.org/rfc/rfc3986#section-3.2.2>`__.

0 commit comments

Comments
 (0)