Skip to content

Correctly handle errors in PyErr_Set*() functions #107915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Aug 13, 2023 · 0 comments · Fixed by #108134
Closed

Correctly handle errors in PyErr_Set*() functions #107915

serhiy-storchaka opened this issue Aug 13, 2023 · 0 comments · Fixed by #108134
Assignees
@serhiy-storchaka
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes topic-C-API type-bug An unexpected behavior, bug, or error

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Aug 13, 2023 •
edited by bedevere-bot
Loading

C API functions PyErr_SetFromErrnoWithFilename(), PyErr_SetExcFromWindowsErrWithFilename(), PyErr_SetFromWindowsErrWithFilename() , _PyErr_SetString() and _PyErr_FormatV() convert some of their arguments from C string to Python string, but do not check for error. If it fails the behavior is undefined -- it can be ignoring the new error and using None or other default value instead of the string, it can be crash.

Linked PRs
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error 3.11 only security fixes topic-C-API 3.12 only security fixes 3.13 bugs and security fixes labels Aug 13, 2023
@serhiy-storchaka serhiy-storchaka self-assigned this Aug 13, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 13, 2023
@serhiy-storchaka
pythongh-107915: Handle errors in C API functions PyErr_Set*() and Py…
fd0ee84 
…Err_Format()

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
@bedevere-bot bedevere-bot mentioned this issue Aug 13, 2023
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 13, 2023
@serhiy-storchaka
pythongh-107915: Handle errors in C API functions PyErr_Set*() and Py…
73586e1 
…Err_Format()

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 13, 2023
@serhiy-storchaka
pythongh-107915: Handle errors in C API functions PyErr_Set*() and Py…
18896cd 
…Err_Format()

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 13, 2023
@serhiy-storchaka
pythongh-107915: Handle errors in C API functions PyErr_Set*() and Py…
3524508 
…Err_Format()

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 13, 2023
@serhiy-storchaka
pythongh-107915: Handle errors in C API functions PyErr_Set*() and Py…
b986253 
…Err_Format()

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
serhiy-storchaka added a commit that referenced this issue Aug 19, 2023
@serhiy-storchaka
gh-107915: Handle errors in C API functions PyErr_Set*() and PyErr_Fo…
633ea21 
…rmat() (GH-107918)

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
@bedevere-bot bedevere-bot mentioned this issue Aug 19, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 19, 2023
@serhiy-storchaka @miss-islington
pythongh-107915: Handle errors in C API functions PyErr_Set*() and Py…
ac100f6 
…Err_Format() (pythonGH-107918)

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
(cherry picked from commit 633ea21)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Aug 19, 2023
@serhiy-storchaka
[3.11] pythongh-107915: Handle errors in C API functions PyErr_Set*()…
c8d7593 
… and PyErr_Format() (pythonGH-107918)

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error..
(cherry picked from commit 633ea21)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Aug 19, 2023
Merged
@serhiy-storchaka serhiy-storchaka linked a pull request Aug 19, 2023 that will close this issue
[3.12] gh-107915: Handle errors in C API functions PyErr_Set*() and PyErr_Format() (GH-107918) #108134
Merged
serhiy-storchaka added a commit that referenced this issue Aug 19, 2023
@serhiy-storchaka
[3.11] gh-107915: Handle errors in C API functions PyErr_Set*() and P…
92a5784 
…yErr_Format() (GH-107918) (GH-108135)

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
(cherry picked from commit 633ea21)
Yhg1s pushed a commit that referenced this issue Aug 20, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-107915: Handle errors in C API functions PyErr_Set*() and P…
97d67e9 
…yErr_Format() (GH-107918) (#108134)

* gh-107915: Handle errors in C API functions PyErr_Set*() and PyErr_Format() (GH-107918)

Such C API functions as PyErr_SetString(), PyErr_Format(),
PyErr_SetFromErrnoWithFilename() and many others no longer crash or
ignore errors if it failed to format the error message or decode the
filename. Instead, they keep a corresponding error.
(cherry picked from commit 633ea21)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

* Define PY_SSIZE_T_CLEAN.

---------

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@da-woods da-woods mentioned this issue Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes topic-C-API type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
1 participant
@serhiy-storchaka