Skip to content

test_sys broken on Python 3.12 under WASI #112503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettcannon opened this issue Nov 28, 2023 · 1 comment
Closed

test_sys broken on Python 3.12 under WASI #112503

brettcannon opened this issue Nov 28, 2023 · 1 comment
Assignees
@ericsnowcurrently
Labels
3.12 only security fixes OS-wasi type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Nov 28, 2023 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

#110713 unconditionally imports test.support.interpreters which imports _xxsubinterpreters which fails since it isn't provided.

This doesn't fail on main because it has a guard against the import:

cpython/Lib/test/test_sys.py

Lines 19 to 22 in 48dfd74

try:
from test.support import interpreters
except ImportError:
interpreters = None

CPython versions tested on:

3.12

Operating systems tested on:

Other

Linked PRs
@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error 3.12 only security fixes OS-wasi labels Nov 28, 2023
@brettcannon brettcannon mentioned this issue Nov 28, 2023
Merged
@bedevere-app bedevere-app bot mentioned this issue Nov 29, 2023
Merged
@ericsnowcurrently
Copy link
Member

Sorry about that. I've opened a PR to fix it.

ericsnowcurrently added a commit that referenced this issue Nov 29, 2023
@ericsnowcurrently
[3.12] gh-112503: Fix test_sys on WASI (gh-112505)
3e6b328 
Skip tests if no interpreters module.gh-110713 added some tests that use the interpreters module but did not accommodated builds that don't support subinterpreters (incl. an interpreters module).  We fix that here by catching ImportError and skipping tests as appropriate.
@github-project-automation github-project-automation bot moved this from Todo to Done in WASI to tier 2 Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsnowcurrently ericsnowcurrently

Labels
3.12 only security fixes OS-wasi type-bug An unexpected behavior, bug, or error
Projects
No open projects
WASI to tier 2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @ericsnowcurrently