Skip to content

Documentation for date and datetime comparison is outdated #114728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Jan 29, 2024 · 0 comments
Closed

Documentation for date and datetime comparison is outdated #114728

serhiy-storchaka opened this issue Jan 29, 2024 · 0 comments
Assignees
@serhiy-storchaka
Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 29, 2024 •
edited by bedevere-app bot
Loading

The implementation of comparison for date and datetime objects was changed 18 years ago, in 1996059, but the documentation still describes the old behavior, with special-casing of other objects with a timetuple attribute. There were also other changes in this code. In particularly, there is a significant difference between equality comparison and order comparison. This part of the documentation should be rewritten.

Linked PRs
@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir 3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes labels Jan 29, 2024
@serhiy-storchaka serhiy-storchaka self-assigned this Jan 29, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Jan 30, 2024
@serhiy-storchaka
pythongh-114728: Fix documentation for comparison of objects in datet…
073c4d1 
…ime module
@bedevere-app bedevere-app bot mentioned this issue Jan 30, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Feb 2, 2024
@serhiy-storchaka
gh-114728: Fix documentation for comparison of objects in datetime mo…
c12240e 
…dule (GH-114749)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 2, 2024
@serhiy-storchaka @miss-islington
pythongh-114728: Fix documentation for comparison of objects in datet…
2d3161d 
…ime module (pythonGH-114749)

(cherry picked from commit c12240e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 2, 2024
@serhiy-storchaka @miss-islington
pythongh-114728: Fix documentation for comparison of objects in datet…
3926a7e 
…ime module (pythonGH-114749)

(cherry picked from commit c12240e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Feb 2, 2024
Merged
Merged
serhiy-storchaka added a commit that referenced this issue Feb 2, 2024
@miss-islington @serhiy-storchaka
[3.11] gh-114728: Fix documentation for comparison of objects in date…
08133e4 
…time module (GH-114749) (GH-114929)

(cherry picked from commit c12240e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue Feb 2, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-114728: Fix documentation for comparison of objects in date…
e9d5324 
…time module (GH-114749) (GH-114928)

(cherry picked from commit c12240e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-114728: Fix documentation for comparison of objects in datet…
49cc031 
…ime module (pythonGH-114749)
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this issue Feb 14, 2024
@serhiy-storchaka @fsc-eriker
pythongh-114728: Fix documentation for comparison of objects in datet…
f6cd1f1 
…ime module (pythonGH-114749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
3.11 only security fixes 3.12 only security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir
Projects
Date and time issues 🕰️
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka