-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-115882: Add missing #include <Unknwn.h> on Windows #115350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Could anyone mark this with skip news label to get the CI green? |
This should have a NEWS entry, please can you add one? |
@hugovk, it looks like generating files in UPD: managed to do this by myself, sorry for disturbing. |
NB: this is not the only patch needed to build CPython with this define. I will have to dig through our patch set to get the remaining ones. |
@hugovk, the CI is green, so two questions arise.
|
I'll leave it to a Windows expert to review.
Generally, bug fixes can be backported for all bugfix branches -- see https://devguide.python.org/versions/ -- currently 3.11 and 3.12. Again, I'll leave it to a Windows expert to decide. |
This one is fine. But no promises that the rest will be fine - I've definitely fixed issues recently by removing I see no reason to backport, as this doesn't fix a bug (neither us nor Microsoft make any promises about things being buildable with |
…15350) This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
…15350) This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
…15350) This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
…15350) This allows the module to be compiled with WIN32_LEAN_AND_MEAN enabled
Fix building ctypes module with
-DWIN32_LEAN_AND_MEAN
defined.See:
https://learn.microsoft.com/en-us/windows/win32/api/unknwn/nn-unknwn-iunknown