-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Remove asyncio
deprecated objects and methods
#119627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is not so straightforward, the subprocesses needs to be reimplemented without watchers before removing it. That has to be done carefully, the code is fragile here with lots of edge cases to deal with. |
I want to get a small advice about will it be enough to keep only one, standart ChildWatcher? |
@SweetyAngel:
I think that implementation could either be
Perhaps we can keep this approach for now, and just remove the deprecated watcher classes? ( |
@SweetyAngel Would you like to continue work on this as Guido suggested? If not I'll take over and do it. |
I ve already done it but i need to move it on new branch. New PR will appear in a few days |
I forgot actually I already have code for this, in a old branch, I'll resolve it and get it done faster. it will also include rewrite on child watchers. |
I am creating a new issue for this with much smaller items to work with. |
Feature or enhancement
Proposal:
There were deprecation warnings on asyncio ChildWatchers and methods, they are connected to. Now they are removed.
Has this already been discussed elsewhere?
No response given
Links to previous discussion of this feature:
No response
The text was updated successfully, but these errors were encountered: