-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Support the "pager" binary in _pyrepl #122878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. IMO it's reasonable to try pager
before less
. On Fedora, there is no pager
command, it will silently be ignored as expected which is fine.
It's user-visible change, I think it worth a changelog entry. |
@stefanor: See https://devguide.python.org/ for how to add a Changelog (NEWS) entry. |
Added a NEWS entry. |
b622900
to
eaf8ae0
Compare
Misc/NEWS.d/next/Core_and_Builtins/2024-09-19-13-17-31.gh-issue-122878.4iFpsB.rst
Outdated
Show resolved
Hide resolved
…e-122878.4iFpsB.rst
Misc/NEWS.d/next/Core_and_Builtins/2024-09-19-13-17-31.gh-issue-122878.4iFpsB.rst
Outdated
Show resolved
Hide resolved
…e-122878.4iFpsB.rst Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy. This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555 (cherry picked from commit 426569e) Co-authored-by: Stefano Rivera <stefano@rivera.za.net>
GH-124242 is a backport of this pull request to the 3.13 branch. |
Merged, thanks @stefanor. |
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy. This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555
Support the "pager" binary in _pyrepl (GH-122878) Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy. This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555 (cherry picked from commit 426569e) Co-authored-by: Stefano Rivera <stefano@rivera.za.net> Co-authored-by: T. Wouters <thomas@python.org>
Debian (and derivatives) provide a /usr/bin/pager binary, managed by the alternatives system, that always points to an available pager utility. Allow _pyrepl to use it, to follow system policy
This is a very trivial change, from a patch that Debian has been carrying since 2.7 era. Seems appropriate to upstream. https://bugs.debian.org/799555