Skip to content

test_class.TestInlineValues.test_detach_materialized_dict_no_memory leaks references #124722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mpage opened this issue Sep 28, 2024 · 3 comments
Closed

test_class.TestInlineValues.test_detach_materialized_dict_no_memory leaks references #124722

mpage opened this issue Sep 28, 2024 · 3 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@mpage
Copy link
Contributor

mpage commented Sep 28, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Refleaks tests are failing on main due to a leak from test_class.TestInlineValues.test_detach_materialized_dict_no_memory:

> ./python -m test -R 3:3 test_class --match test.test_class.TestInlineValues.test_detach_materialized_dict_no_memory
Using random seed: 1105673167
0:00:00 load avg: 1.71 Run 1 test sequentially in a single process
0:00:00 load avg: 1.71 [1/1] test_class
beginning 6 repetitions. Showing number of leaks (. for 0 or less, X for 10 or more)
123:456
XX1 111
test_class leaked [1, 1, 1] references, sum=3
test_class leaked [1, 1, 1] memory blocks, sum=3
test_class failed (reference leak)

== Tests result: FAILURE ==

1 test failed:
    test_class

Total duration: 223 ms
Total tests: run=1 (filtered)
Total test files: run=1/1 (filtered) failed=1
Result: FAILURE
>

That test was added in gh-124627.
cc @markshannon @DinoV

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@mpage mpage added the type-bug An unexpected behavior, bug, or error label Sep 28, 2024
@picnixz picnixz added the tests Tests in the Lib/test dir label Sep 28, 2024
@picnixz picnixz mentioned this issue Sep 28, 2024
Merged
@ZeroIntensity
Copy link
Member

I'll look into this soon. At a glance, the leak itself is probably not related to the PR.

sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 29, 2024
@sobolevn
pythongh-124722: Fix leak in test_detach_materialized_dict_no_memory
d42f6c0
@bedevere-app bedevere-app bot mentioned this issue Sep 29, 2024
Merged
@sobolevn
Copy link
Member

@ZeroIntensity sorry, I didn't write a message here. I was also working on this issue.
Please, take a look at my PR: #124769

sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 29, 2024
@sobolevn
pythongh-124722: Fix leak in test_detach_materialized_dict_no_memory
e7a409b
@ZeroIntensity
Copy link
Member

Oh, perfect! I'll take a look at the PR.

zware pushed a commit that referenced this issue Sep 30, 2024
@sobolevn
gh-124722: Fix leak in test_detach_materialized_dict_no_memory (GH-…
6f4d64b 
…124769)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 30, 2024
@sobolevn @miss-islington
pythongh-124722: Fix leak in test_detach_materialized_dict_no_memory (
73d7d1b 
pythonGH-124769)

(cherry picked from commit 6f4d64b)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue Sep 30, 2024
Merged
Yhg1s pushed a commit that referenced this issue Sep 30, 2024
@miss-islington @sobolevn
[3.13] gh-124722: Fix leak in `test_detach_materialized_dict_no_memor…
ce0eaa6 
…y` (GH-124769) (#124777)

gh-124722: Fix leak in `test_detach_materialized_dict_no_memory` (GH-124769)
(cherry picked from commit 6f4d64b)

Co-authored-by: sobolevn <mail@sobolevn.me>
@mpage mpage closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mpage @sobolevn @picnixz @ZeroIntensity