Skip to content

Check EX_OK is defined before including sysexits.h means it is always redefined #129539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
collinfunk opened this issue Feb 1, 2025 · 2 comments
Closed

Check EX_OK is defined before including sysexits.h means it is always redefined #129539

collinfunk opened this issue Feb 1, 2025 · 2 comments
Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@collinfunk
Copy link
Contributor

collinfunk commented Feb 1, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Minor nit, but there is a check for the definition of EX_OK before sysexits.h is included. Meaning it is always redefined when that header exists.

  In file included from ./Modules/posixmodule.c:295:
  /usr/include/sysexits.h:92:9: warning: "EX_OK" redefined
     92 | #define EX_OK           0       /* successful termination */
        |         ^~~~~ 
  ./Modules/posixmodule.c:56:11: note: this is the location of the previous definition
     56 | #  define EX_OK EXIT_SUCCESS
      |           ^~~~~

The C standard says redefinition's like this aren't allowed, but in practice I've only seen compilers warn about them.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@collinfunk collinfunk added the type-bug An unexpected behavior, bug, or error label Feb 1, 2025
collinfunk added a commit to collinfunk/cpython that referenced this issue Feb 1, 2025
@collinfunk
pythongh-129539: Include sysexits.h before checking EX_OK
0cbd65d 
Previously the macro would be redefined when the header was included.
@bedevere-app bedevere-app bot mentioned this issue Feb 1, 2025
Closed
@picnixz picnixz added the extension-modules C modules in the Modules dir label Feb 1, 2025
collinfunk added a commit to collinfunk/cpython that referenced this issue Feb 1, 2025
@collinfunk
pythongh-129539: Include sysexits.h before checking EX_OK
ef40eea 
Previously the macro would be redefined when the header was included.
collinfunk added a commit to collinfunk/cpython that referenced this issue Feb 1, 2025
@collinfunk
pythongh-129539: Include sysexits.h before checking EX_OK
4d1df0d 
Previously the macro would be redefined when the header was included.
vstinner added a commit to vstinner/cpython that referenced this issue Feb 1, 2025
@vstinner
pythongh-129539: Reorganize posixmodule.c header
f18aef9 
Add sections: Python includes, system includes, etc.

Add a comment explaining why an include is needed.
vstinner added a commit to vstinner/cpython that referenced this issue Feb 1, 2025
@vstinner
pythongh-129539: Reorganize posixmodule.c header
d778cde 
Add sections: Python includes, system includes, etc.

Add a comment explaining why an include is needed.
@bedevere-app bedevere-app bot mentioned this issue Feb 1, 2025
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Feb 1, 2025
@vstinner
pythongh-129539: Reorganize posixmodule.c header
372bfb4 
Add sections: Python includes, system includes, etc.

Add a comment explaining why an include is needed.
vstinner added a commit that referenced this issue Feb 2, 2025
@vstinner
gh-129539: Reorganize posixmodule.c header (#129558)
df4a2f5 
Add sections: Python includes, system includes, etc.

Add a comment explaining why an include is needed.
collinfunk added a commit to collinfunk/cpython that referenced this issue Feb 2, 2025
@collinfunk
pythongh-129539: Include sysexits.h before checking EX_OK
2fdfee1 
Previously the macro would be redefined when the header was included.
@bedevere-app bedevere-app bot mentioned this issue Feb 2, 2025
Merged
vstinner pushed a commit that referenced this issue Feb 2, 2025
@collinfunk
[3.13] gh-129539: Include sysexits.h before checking EX_OK (#129590)
65f3432 
Previously, the macro would be redefined when the header was included.
@bedevere-app bedevere-app bot mentioned this issue Feb 3, 2025
Merged
@vstinner
Copy link
Member

vstinner commented Feb 3, 2025

Fixed in 3.13 and main branch, the 3.12 backport is on going. Thanks for the fix and the bug report.

@vstinner vstinner closed this as completed Feb 3, 2025
vstinner added a commit that referenced this issue Feb 3, 2025
@vstinner @collinfunk
[3.12] gh-129539: Include sysexits.h before checking EX_OK (#129590) (#…
6186021 
…129609)

[3.13] gh-129539: Include sysexits.h before checking EX_OK (#129590)

Previously, the macro would be redefined when the header was included.

(cherry picked from commit 65f3432)

Co-authored-by: Collin Funk <collin.funk1@gmail.com>
@collinfunk
Copy link
Contributor Author

Thanks for backporting it to 3.12 for me!

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Feb 7, 2025
@vstinner @srinivasreddy
pythongh-129539: Reorganize posixmodule.c header (python#129558)
4870aa4 
Add sections: Python includes, system includes, etc.

Add a comment explaining why an include is needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @picnixz @collinfunk