-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Rewrite the fcntl module #132742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@vstinner, was there a reason to not retry |
It seems that |
It seems that string argument can be used with |
Test with different types of argument: integer, mutable and immutable buffers, immutable buffer with mutable_flag set to false.
Test with different types of argument: integer, mutable and immutable buffers, immutable buffer with mutable_flag set to false.
Test with different types of argument: integer, mutable and immutable buffers, immutable buffer with mutable_flag set to false. (cherry picked from commit a04390b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
POSIX required (until removed in POSIX.1-2024) the |
* Do not skip ALL ioctl() tests when /dev/tty is not available. * Use better tests for integer argument. * Add also parallel tests for tcflush() and tcflow().
* Support arbitrary bytes-like objects, not only bytes, in fcntl(). * The fcntl() buffer argument is now null-terminated. * Automatically retry an ioctl() system calls failing with EINTR. * Release the GIL for an ioctl() system call even for large bytes-like object. * Do not silence arbitrary errors whet try to get a buffer. * Optimize argument parsing, check the argument type before trying to get a buffer or convert it to integer. * Fix some error messages.
* Use better tests for integer argument. * Add also parallel tests for tcflush() and tcflow().
) * Use better tests for integer argument. * Add also parallel tests for tcflush() and tcflow(). (cherry picked from commit ed8e886) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
The current code of the
fcntl
module is a little mess. This was caused particularly by the nature of the underlying C API (fcntl()
andioctl()
take an argument as a C int or a pointer to a structure, and the type of the argument, as well as the size of the structure is not explicitly specified, but depends on opcode and is platform depending), and particularly by the decades of incremental changes.At Python level,
fcntl()
andioctl()
take an optional argument which can be an integer, a string, or a mutable or immutable bytes-like object. The result can be an integer or a bytes object. The input mutable bytes-like object can be modified in-place inioctl()
. Issues, differences and inconsistencies betweenfcntl()
andioctl()
:ioctl()
first try to interpret the argument as a mutable bytes-like object, then as a string or immutable bytes-like object, then as an integer.fcntl()
does the same except trying a mutable bytes-like object. Raising and silencing exceptions is not particularly efficient, and silencing arbitrary exceptions is not good.fcntl()
andioctl()
accept string argument. This looks like an unintentional side effect in Python 2 which was not fixed in Python 3. I do not know any operation code which takes a string argument -- they take binary structures. Even if there is an operation which takes a char array, most likely it should be encoded using filesystem encoding instead of UTF-8, sobytes
is more preferable thanstr
. String argument should be deprecated.ioctl()
makes the temporary buffer null-terminated, butfcntl()
does not.ioctl()
has themutate_arg
parameter, butfcntl()
does not, even if some operations mutate argument.ioctl()
copies the content of the mutable bytes-like object to a temporary buffer ifmutate_arg
is true and it fits in a buffer, and then copies it back. It was needed when the parsing code used "w#", because the object could be resized after releasing the GIL. And it was wrong, because copying back will not work after resizing. But now "w*" is used ("w#" no longer supported), so no copying to temporary buffer is needed.ioctl()
does not release the GIL when call the Cioctl()
if the mutable bytes-like object does not fit in the temporary buffer. It can, for reasons described above.ioctl()
accepts opcode asunsigned int
unsigned long
,fcntl()
accepts onlyint
.fcntl()
accepts the integer argument asunsigned int
,ioctl()
accepts onlyint
. Using an unsigned format makes the code more error-prone (Deprecate accepting out of range values for unsigned integers in PyArg_Parse #132629 should mitigate this), but makes it more usable if some opcode or value constants in C has the MSB set. I think that both function should acceptunsigned int
(unsigned long
?) for both arguments.fcntl()
automatically retries on EINTR,ioctl()
raises an OSError.Linked PRs
The text was updated successfully, but these errors were encountered: