You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In hashlib.h, we have a HASHLIB_GIL_MINSIZE constant that we could expose as hashlib.GIL_MINSIZE. For now it's a read-only constant since the constant is shared across multiple modules (_hashlib and HACL*-based primitives).
Since _hashlib may be missing but _md5 may not, it's better to place that constant in all modules. However, for it to be read-only, we should make it available in all modules it is shared by. That way, we can always have access to it for desired module and we can also change its per-module behavior in the future.
Note: this is typically useful in tests where for now it's always hardcoded.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Feature or enhancement
Proposal:
In
hashlib.h
, we have a HASHLIB_GIL_MINSIZE constant that we could expose ashashlib.GIL_MINSIZE
. For now it's a read-only constant since the constant is shared across multiple modules (_hashlib
and HACL*-based primitives).Since
_hashlib
may be missing but_md5
may not, it's better to place that constant in all modules. However, for it to be read-only, we should make it available in all modules it is shared by. That way, we can always have access to it for desired module and we can also change its per-module behavior in the future.Note: this is typically useful in tests where for now it's always hardcoded.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
HASHLIB_GIL_MINSIZE
to private extension modules #132999The text was updated successfully, but these errors were encountered: