Skip to content

PEP 750 changes do no guard for usage with older versions like ast.parse(t'', feature_version=(3, 13)) #133196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Apr 30, 2025 · 2 comments
Closed

PEP 750 changes do no guard for usage with older versions like ast.parse(t'', feature_version=(3, 13)) #133196

sobolevn opened this issue Apr 30, 2025 · 2 comments
Assignees
@sobolevn
Labels
3.14 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-parser type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Apr 30, 2025 •
edited by bedevere-app bot
Loading

Bug report

Example:

>>> code = 't""'
>>> import ast
>>> ast.parse(code, feature_version=(3, 8))
Module(body=[Expr(value=TemplateStr(values=[]))], type_ignores=[])

I would like to work on the fix.

Linked PRs
@sobolevn sobolevn added 3.14 new features, bugs and security fixes topic-parser type-bug An unexpected behavior, bug, or error labels Apr 30, 2025
@sobolevn sobolevn self-assigned this Apr 30, 2025
@sobolevn sobolevn changed the title PEP 750 changes do no guard for usage with older versions like ast.parse(..., feature_version=(3, 13)) PEP 750 changes do no guard for usage with older versions like ast.parse(t'', feature_version=(3, 13)) Apr 30, 2025
@sobolevn
Copy link
Member Author

cc @lysnikolaou

@lysnikolaou
Copy link
Member

@sobolevn Thanks for the issue. Ping me on the PR when you've opened it.

sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 30, 2025
@sobolevn
pythongh-133196: Improve error message for ft"" case
4f57f3d
@bedevere-app bedevere-app bot mentioned this issue Apr 30, 2025
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 30, 2025
@sobolevn
pythongh-133196: Guard PEP 750 grammar with CHECK_VERSION
bf5b0fa
@bedevere-app bedevere-app bot mentioned this issue Apr 30, 2025
Merged
lysnikolaou pushed a commit that referenced this issue May 1, 2025
@sobolevn
gh-133196: Guard PEP 750 grammar with CHECK_VERSION (#133225)
5cdd49b
@picnixz picnixz added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
3.14 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-parser type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sobolevn @picnixz @lysnikolaou