Skip to content

Use HAS_TARGET in the codegen_addop_j function #133279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nybblista opened this issue May 2, 2025 · 1 comment
Open

Use HAS_TARGET in the codegen_addop_j function #133279

nybblista opened this issue May 2, 2025 · 1 comment

Comments

@nybblista
Copy link
Contributor

nybblista commented May 2, 2025 •
edited by bedevere-app bot
Loading

I think we should assert with HAS_TARGET in the definition of the codegen_addop_j function rather than using OPCODE_HAS_JUMP and IS_BLOCK_PUSH_OPCODE directly in the function itself.

Linked PRs
@bedevere-app bedevere-app bot mentioned this issue May 2, 2025
Open
@nybblista
Copy link
Contributor Author

nybblista commented May 2, 2025 •
edited
Loading

@iritkatriel @markshannon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nybblista