Skip to content

Remove C variadic constructor signature support for threading.RLock #134087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
picnixz opened this issue May 16, 2025 · 0 comments
Closed

Remove C variadic constructor signature support for threading.RLock #134087

picnixz opened this issue May 16, 2025 · 0 comments
Assignees
@picnixz
Labels
extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@picnixz
Copy link
Member

picnixz commented May 16, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Passing any arguments has been deprecated since Python 3.14, as the Python version does not permit any arguments, but the C version allows any number of positional or keyword arguments, ignoring every argument.

Linked PRs
@picnixz picnixz added type-feature A feature request or enhancement extension-modules C modules in the Modules dir labels May 16, 2025
@picnixz picnixz changed the title Remove C variadic constructor signature support threading.RLock Remove C variadic constructor signature support for threading.RLock May 16, 2025
@picnixz picnixz self-assigned this May 18, 2025
@bedevere-app bedevere-app bot mentioned this issue May 18, 2025
Merged
picnixz added a commit that referenced this issue May 19, 2025
@picnixz
gh-134087: enforce signature of threading.RLock (#134178)
d6dc33e 
- Reject positional and keyword arguments in `_thread.RLock.__new__`.
- Convert `_thread.lock.__new__` to AC.
@picnixz picnixz closed this as completed May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@picnixz picnixz

Labels
extension-modules C modules in the Modules dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@picnixz