Skip to content

Update MSVC PGO options #134923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zooba opened this issue May 30, 2025 · 0 comments
Closed

Update MSVC PGO options #134923

zooba opened this issue May 30, 2025 · 0 comments
Assignees
@zooba
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 new features, bugs and security fixes build The build process and cross-build OS-windows

Comments

@zooba
Copy link
Member

zooba commented May 30, 2025 •
edited by bedevere-app bot
Loading

The linker options we currently use for PGO on Windows are deprecated and should be updated to /GENPROFILE and /USEPROFILE.

No idea whether this will affect the optimization of the results, but it's general goodness anyway to make sure we don't suddenly stop working if/when the compiler drops the old option entirely.

Linked PRs
@zooba zooba self-assigned this May 30, 2025
@zooba zooba added OS-windows build The build process and cross-build 3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 new features, bugs and security fixes labels May 30, 2025
@bedevere-app bedevere-app bot mentioned this issue May 30, 2025
Merged
zooba added a commit to zooba/cpython that referenced this issue May 30, 2025
@zooba
pythongh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds
25f01a3
zooba added a commit that referenced this issue May 30, 2025
@zooba
gh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds (GH…
8865b4f 
…-134924)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 30, 2025
@zooba @miss-islington
pythongh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO buil…
daa84bc 
…ds (pythonGH-134924)

(cherry picked from commit 8865b4f)

Co-authored-by: Steve Dower <steve.dower@python.org>
This was referenced May 30, 2025
Merged
Merged
zooba added a commit that referenced this issue May 30, 2025
@zooba
gh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds (GH…
5fd62be 
…-134924)
zooba added a commit that referenced this issue May 30, 2025
@miss-islington @zooba
gh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds (GH…
32574d4 
…-134924)

(cherry picked from commit 8865b4f)

Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba zooba closed this as completed May 30, 2025
This was referenced Jun 9, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zooba zooba

Labels
3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 new features, bugs and security fixes build The build process and cross-build OS-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zooba