Skip to content

regen autotools related files #77667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grimreaper mannequin opened this issue May 13, 2018 · 7 comments
Closed

regen autotools related files #77667

grimreaper mannequin opened this issue May 13, 2018 · 7 comments
Labels
3.7 (EOL) end of life 3.8 (EOL) end of life build The build process and cross-build type-feature A feature request or enhancement

Comments

@grimreaper
Copy link
Mannequin

grimreaper mannequin commented May 13, 2018

BPO 33486
Nosy @malemburg, @gvanrossum, @warsaw, @birkenfeld, @benjaminp, @tarekziade, @ned-deily, @merwok, @encukou, @serhiy-storchaka, @grimreaper, @matrixise
PRs
  • bpo-33486: regen autotools related files #6783
  • bpo-33486: regen autotools files using autoupdate+autoreconf #6853
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2018-05-13.19:08:03.281>
labels = ['3.8', 'type-feature', '3.7', 'build']
title = 'regen autotools related files'
updated_at = <Date 2018-11-04.19:43:41.906>
user = 'https://github.com/grimreaper'

    bugs.python.org fields:

    activity = <Date 2018-11-04.19:43:41.906>
actor = 'ned.deily'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Build']
creation = <Date 2018-05-13.19:08:03.281>
creator = 'eitan.adler'
dependencies = []
files = []
hgrepos = []
issue_num = 33486
keywords = ['patch']
message_count = 7.0
messages = ['316477', '316625', '316629', '325411', '325412', '329249', '329250']
nosy_count = 13.0
nosy_names = ['lemburg', 'gvanrossum', 'barry', 'anthonybaxter', 'georg.brandl', 'benjamin.peterson', 'tarek', 'ned.deily', 'eric.araujo', 'petr.viktorin', 'serhiy.storchaka', 'eitan.adler', 'matrixise']
pr_nums = ['6783', '6853']
priority = 'normal'
resolution = None
stage = 'commit review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33486'
versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']
    @grimreaper
    Copy link
    Mannequin Author

    grimreaper mannequin commented May 13, 2018

    There are few if any functional changes, but this is helpful when making other changes to the build system.

    @grimreaper grimreaper mannequin added build The build process and cross-build type-feature A feature request or enhancement labels May 13, 2018
    @serhiy-storchaka
    Copy link
    Member

    If these changes are autogenerated, I would prefer that a trusted core developer create a PR.

    Is it safe to bump the minimal required version of autotools to 2.69? This can prevent building Python on conservative systems.

    @grimreaper
    Copy link
    Mannequin Author

    grimreaper mannequin commented May 15, 2018

    If these changes are autogenerated, I would prefer that a trusted core developer create a PR.

    They are fully auto-generated (using autoupdate and autoreconf). It someone else wants to submit the PR, feel free.

    Is it safe to bump the minimal required version of autotools to 2.69? This can prevent building Python on conservative systems.

    This should only affect rerunning autoreconf and related tools. It won't affect the use of "configure" (and therefore "make") which is checked into the repository.

    @encukou
    Copy link
    Member

    encukou commented Sep 14, 2018

    If these changes are autogenerated, I would prefer that a trusted core developer create a PR.

    I got the same changes in configure.ac.

    @encukou
    Copy link
    Member

    encukou commented Sep 14, 2018

    New changeset 24f6846 by Petr Viktorin (Eitan Adler) in branch 'master':
    bpo-33486: regen autotools files using autoupdate+autoreconf (GH-6853)
    24f6846

    @encukou encukou closed this as completed Sep 14, 2018
    @ned-deily
    Copy link
    Member

    If we are going to bump the tools version from 2.65 to 2.69 for master, we should probably bump them for all active branches. It creates confusion and makes backporting more difficult. Besides, it appears that, at the moment, the checked-in configure files for 3.7, 3.6, and 2.7 were all generated with 2.69 anyway :) if doing so, the reference to 2.65 in the devguide setup.rst should also be updated.

    @ned-deily ned-deily added 3.7 (EOL) end of life 3.8 (EOL) end of life labels Nov 4, 2018
    @ned-deily ned-deily reopened this Nov 4, 2018
    @matrixise
    Copy link
    Member

    Hi Ned, thanks for this clarification

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 (EOL) end of life build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @matrixise @encukou @serhiy-storchaka @ned-deily @kumaraditya303