Skip to content

PEP 686: Emit EncodingWarning in more places. #91954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
methane opened this issue Apr 26, 2022 · 0 comments · Fixed by #91977
Closed

PEP 686: Emit EncodingWarning in more places. #91954

methane opened this issue Apr 26, 2022 · 0 comments · Fixed by #91977
Labels
type-feature A feature request or enhancement

Comments

@methane
Copy link
Member

methane commented Apr 26, 2022

Feature or enhancement

Emit EncodingWarning in subprocess.Popen(text=True) and locale.getpreferredencoding().

Pitch

UTF-8 Mode will affect them. So we need to emit EncodingWarning like open().

See PEP 686 for detail.
@methane methane added the type-feature A feature request or enhancement label Apr 26, 2022
@methane methane mentioned this issue Apr 27, 2022
Merged
methane added a commit that referenced this issue Apr 30, 2022
@methane
gh-91954: Emit EncodingWarning from locale and subprocess (GH-91977)
354ace8 
locale.getpreferredencoding() and subprocess.Popen() emit EncodingWarning
sweeneyde added a commit that referenced this issue May 1, 2022
@sweeneyde
gh-91954: Use shell=True in test_subprocess.test_encoding_warning (GH…
b963618 
…-92090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-91954: Emit EncodingWarning from locale and subprocess methane/cpython
1 participant
@methane